OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
17 stars 1 forks source link

Unsatisfiable warning about mismatched date when EDTF date specifies a time #764

Open 1ec5 opened 1 month ago

1ec5 commented 1 month ago

If a start_date:edtf or end_date:edtf tag specifies the time of day, the validator warns that the corresponding start_date or end_date tag falls outside the EDTF date range. This is technically true, but only because the start_date and end_date keys are limited to day precision and don’t accept times. The suggested fix does nothing, since it is correctly truncated at the day of the month. The validator should not warn about a mismatched date in this case.

[2013 – ] has a start date that falls outside of the EDTF start date

https://github.com/OpenHistoricalMap/iD/blob/87d6795e91606953fb1c9a5bd8caba1ad4bc1ed4/modules/validations/mismatched_dates.js#L108-L110