iD.validations.crossing_ways test fails — flags sidewalk crossing service road

OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.

Creative Commons Zero v1.0 Universal

19 stars 1 forks source link

iD.validations.crossing_ways test fails — flags sidewalk crossing service road #766

Closed 1ec5 closed 6 months ago

1ec5 commented 7 months ago

@erictheise noticed a while ago that this test started failing:

Chrome Headless 123.0.6312.105 (Linux x86_64) iD.validations.crossing_ways flags sidewalk crossing service road FAILED AssertionError: expected [ validationIssueFix{ …(8) }, …(5) ] to have a length of 5 but got 6 at Context. (test/spec/validations/crossing_ways.js:273:38)

https://github.com/OpenHistoricalMap/iD/blob/87d6795e91606953fb1c9a5bd8caba1ad4bc1ed4/test/spec/validations/crossing_ways.js#L273

1ec5 commented 7 months ago

This is due to the “Change the Start Date and End Date” dynamic fix that was introduced in OpenHistoricalMap/iD#137. I don’t know why it didn’t come up when I was fixing the tests in OpenHistoricalMap/iD#195.

Service Road crosses Sidewalk during the same time period: Connect the features, Connect using a crossing, Add a bridge, Add a tunnel, Change the Start Date and End Date, Reposition the features, Ignore this issue