OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
17 stars 1 forks source link

HTTP errors loading nonexistent Natural Earth tiles at mid-to-high zoom levels #794

Open 1ec5 opened 3 months ago

1ec5 commented 3 months ago

The Historical layer is producing many errors like this in Firefox’s console when you zoom to levels 11 and above:

Object { message: "Decoding failed.", stack: "" }
application-d966bda7fa32d5f5120b61a5160ac09034ea743352a0d004db76c5ebf28667ae.js:183:6024

which correspond to failed network requests for URLs like https://vtiles.openhistoricalmap.org/maps/ne/16/17423/24991.pbf:

HTTP/2 404 
date: Sun, 26 May 2024 22:06:31 GMT
content-type: text/plain; charset=utf-8
content-length: 35
access-control-allow-methods: GET, OPTIONS
access-control-allow-origin: *
content-encoding: gzip
tegola-cache: MISS
x-content-type-options: nosniff
strict-transport-security: max-age=31536000; includeSubDomains
X-Firefox-Spdy: h2

OpenHistoricalMap/map-styles@b1603f378d57e8040d43d0e2fdc804e4f0c05774 added a reference to this “ne” source, which comes from Natural Earth, to the Historical stylesheet. OpenHistoricalMap/ohm-deploy@90f7fb08067c756dea230e2bad17005b1918a5cf for OpenHistoricalMap/ohm-deploy#293 appears to have limited this tileset to just zoom levels 0 through 10, so any requests for zoom levels 11 and above will fail. The stylesheet should set the maxzoom property so MapLibre GL JS doesn’t request resources we know don’t exist.

Rub21 commented 3 months ago

I have extend the zoom level and for Natural Earth waterbodies https://vtiles.openhistoricalmap.org/#8.93/50.0543/-75.2051

jeffreyameyer commented 3 months ago

Wait! We do not want Natural Earth waterbodies in higher zoom levels.

The original vtiles settings were correct.

The stylesheet selection of z=0-20 was what needed to be fixed to match.

We need to have a cutover where the waterbodies stop coming from Natural Earth and start coming from the OHM database.

E.g. NED: Zoom 0-8 OHM: Zoom 9-20

And the vtiles and the stylesheets should match for these two.

Does that make sense?

danrademacher commented 3 months ago

Ok, so Ruben to update TOML and then @vknoppkewetzel needs to fix any stylesheets that call Natural Earth at z9+ to remove those calls to match:

NED: Zoom 0-8 OHM: Zoom 9-20

vknoppkewetzel commented 3 months ago

updates all styles, now in map-styles repo

Rub21 commented 3 months ago

The NE water has been updated from zoom 0 to 8

image
Rub21 commented 3 months ago

Seems the config in map-styles are still from zoom 0 - 24

      "id": "water_areas-ne",
      "type": "fill",
      "source": "ne",
      "source-layer": "water_areas",
      "minzoom": 0,
      "maxzoom": 24,

https://github.com/OpenHistoricalMap/map-styles/blob/deploy-cleanup/main/main.json#L678-L679

cc. @vknoppkewetzel

vknoppkewetzel commented 3 months ago

hmmm I am not seeing that on my end.

image image

vknoppkewetzel commented 3 months ago

Is that pulling from Dan's changes where stuff will be renamed to main I think the main stuff hasn't been finalized , the latest is still in tegola-ohm stuff :)