OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
17 stars 1 forks source link

Vector tiles should omit name from boundary lines #798

Open 1ec5 opened 3 months ago

1ec5 commented 3 months ago

As of #701, the vector tiles include a point feature for each boundary relation, corresponding to either the boundary’s centroid or label. We expect stylesheets to label boundaries based on these point features rather than the boundary linestring features themselves. The tiler should now omit the name property, because it’s no longer needed for rendering purposes.

jeffreyameyer commented 3 months ago

I can see the issues #800 will create with name assignation to boundary segments, but won't this preclude naming along boundaries, like this?

Monosnap OpenStreetMap 2024-06-03 11-57-26
1ec5 commented 3 months ago

800 will remove the ability to label boundary edges as depicted in that screenshot. It was straightforward when we represented each boundary as a polygon, because the renderer can easily tell which side of the polygon ring is inside or outside. It remains somewhat possible, with caveats, because each linestring is still a complete ring, with the winding order most likely matching the polygon ring it replaced. But once we dissolve the linestrings so that they no longer form rings, a linestring’s direction will no longer correspond at all to the “correct” direction of an outer or inner ring.

Simultaneously, #800 will unblock a more robust implementation of boundary edge labels. I hope that we’ll be able to reason about whether the left or right side of a boundary way corresponds to the inside or outside of any of the boundary relations that it runs along. If so, we’d copy the names into properties like name:left, name:right, name:left:en, etc.

jeffreyameyer commented 3 months ago

👍 Sounds like a plan - just wanted to make sure that had been considered & it was!