search

OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

Wonky rendering of some ways #871

Closed rwelty1889 closed 3 months ago

rwelty1889 commented 3 months ago

ways that have a bunch of points in the DB are being wildly oversimplified in the tiles.

go to the following link, look at the jagged representation of the railway and monorail and compare to the ways in the database.

https://www.openhistoricalmap.org/#map=17/28.41730/-81.58227&layers=O&date=1999-08-12&daterange=1824-01-01,2024-12-31

1ec5 commented 3 months ago

OpenHistoricalMap/ohm-deploy@3ce8b5c6ee15b95631acafd2e9d8458b02059432 made some major changes to the transportation layers for OpenHistoricalMap/issues#869. Similar to the railways you noticed, streets are also oversimplified, and highway=residential is entirely missing.

For example, if you open this area in iD and enable OHM vector tiles as a custom data layer, you can see that roads are straightened out artificially, and no features represent any highway=residential streets:

West Loveland Avenue as a straight line despite an S-curve in reality. Englage Avenue present in the data but not in the tiles.

@Rub21, it looks like all the transport_lines_* layers are based on the osm_transport_lines_gen1 table now, with the exception of transport_lines_gen_5 being based on osm_transport_lines_gen0. None of the layers is based on osm_transport_lines anymore. Is this intentional?

Rub21 commented 3 months ago

Sorry, this is my bad. I mixed up some tables in the latest commit, but I just fixed it

image
1ec5 commented 3 months ago

Looks good. Thank you for the quick turnaround!

1ec5 commented 3 months ago

The lines are back but several attributes are still missing: #872.