OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

Review the new version of Task Manager #879

Open Rub21 opened 2 months ago

Rub21 commented 2 months ago

The tasks https://github.com/OpenHistoricalMap/issues/issues/876 and https://github.com/OpenHistoricalMap/issues/issues/867 have been completed. Now, the new task manager needs to be reviewed. @karitotp, could you spend some time reviewing the staging version https://tasks-staging.openhistoricalmap.org/ in order to merge it into production?

karitotp commented 2 months ago

Hey @Rub21, I have conducted several tests on the site, focusing primarily on the following checklist. While most functionalities are working correctly, I found the following cases, let me know if there is anything that needs further clarification.

  1. Task edition in ID editor is not working

    Steps to reproduce:

    • Go to a project
    • Select a task to map in ID editor
    • The following message is displayed in the ID interface

Selection_2489

  1. Draft projects are not loading, it returns Project not found

    Steps to reproduce as admin user:

    • Go to Manage tab > Projects tabs > Draft option
    • Select one of the draft
    • It returns Project not found
  2. Campaign and Organization drop-downs should also filter Draft projects?

    Steps to reproduce as admin user:

    • Go to Manage tab > Projects tabs
    • Select the Organization with which a project draft was created
    • The draft project is not displayed

Selection_2487

  1. The URLs for OHM website: https://tasks-staging.openhistoricalmap.org/openhistoricalmap.org and Copyright: https://tasks-staging.openhistoricalmap.org/staging.openhistoricalmap.org/copyright are returning a 'Page Not Found' error.
Rub21 commented 2 months ago

@erictheise any idea about the OHM- API in TM frontend?

Rub21 commented 2 months ago

I’ve been trying to debug the iD issue. It seems that it’s not taking the OSM_SERVER_URL in the compilation, and is instead using the current URL, resulting in a request to: https://tasks-staging.openhistoricalmap.org/projects/1/validate/undefined/api/0.6/map?bbox=2.7685546874999822,50.3454604086048,2.8124999999999827,50.3734961443035. when it should be https://staging.openhistoricalmap.org/api/0.6/map?bbox=2.7685546874999822,50.3454604086048,2.8124999999999827,50.3734961443035

image

Rub21 commented 2 months ago

@erictheise I have tested deploying the HOT TM frontend in and it works the iD, maybe something is missing in our version image

erictheise commented 2 months ago

@Rub21, as we discussed at the last all-hands, the version of iD our tasking-manager uses is a three year old build it pulls in from npm. I published a newer version a few days ago just to make sure it could be done but it's not completely caught up with the latest changes. I was going over the Node version conflicts yesterday and hope to resolve them today.