Water areas missing at z8

[1ec5]

As reported on Discord, water areas such as the Great Lakes are missing at vector zoom level 8 (raster zoom level 9):

https://github.com/OpenHistoricalMap/issues/issues/794#issuecomment-2142229776 limited Natural Earth water areas to zoom levels 0–8. The OHM-based layers appear to include the lakes at z8. The Historical stylesheet source water areas from Natural Earth at z0–8 and from OHM at z9–24. This leaves a gap between zoom levels 8 and 9, because the maxzoom property is not inclusive.

I’m unsure how this has been working up until recently. Maybe the recent work to trim unrendered features out of the tiles affected the water areas too? Anyhow, the fix is probably to adjust the stylesheet’s water_areas layer to start a z8 instead of z9.

[vknoppkewetzel]

Hi! This was intentional because OHM only shows integer-based zoom levels (and not incrementally in between).

I can adjust to have them begin at 8, however.

[1ec5]

Actually it looks like the Great Lakes are missing at multiple zoom levels. Can you take a look at it on the main website? I’m not sure why that’s happening.

[vknoppkewetzel]

Taking a look, seeing it as i zoom in. Wonder if something with the expression changed happened! Diving in

[vknoppkewetzel]

I'm having trouble consistently replicating there being "no water" at other zooms. both in OHM and in Maptnik. Sometimes loads white, sometimes at same zoom, loads white. So now I am suspecting it is a loading issue?? It isn't consistent for me.

In the latest map-styles update (OHM main site pending for next prod release) , adjusted water areas to come in at z8.

Because I could not consistently duplicate the issue occurring, I could not resolve that stylistically. I don't understand either how it can be a loading issue because the site was so snappy before.

For example, I see tile edges of "disappeared, but also not disappeared"

[1ec5]

Ah, I see what you mean. That’s more of a GL JS performance issue. So the only thing actionable on our side is to restore water at vector z8 (raster z9):

https://embed.openhistoricalmap.org/#map=8/41.512/-82.24

[vknoppkewetzel]

yes, got that change in the map-styles repo!

[Rub21]

@vknoppkewetzel , let me know if you need help to deploy these changes in production!!

[vknoppkewetzel]

Hi @Rub21 yes if this isn't deployed yet, please feel free to deploy! 🙌 ty for checking in 🙏

[vknoppkewetzel]

I believe this is resolved now?

closing out