search

OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

About page has broken link to copyright page #884

Open 1ec5 opened 2 months ago

1ec5 commented 2 months ago

As reported on Discord, the about page includes the following passage:

See the Copyright and License page for details.

which links to a nonexistent https://www.openhistoricalmap.org/%%7Bcopyright_path%7D. It should link instead to the Copyright page.

The about page is including the site.about.open_data_html message without passing in a value for copyright_path:

https://github.com/OpenHistoricalMap/ohm-website/blob/17f7bfd284a63ea1e4de93195e2d1d131e525e12/app/views/site/about.html.erb#L35

Compare the equivalent (very old) openstreetmap-website code:

https://github.com/openstreetmap/openstreetmap-website/blob/a91afa0e78a5fa3e54aee38ec64c43fcea0b7abb/app/views/site/about.html.erb#L29

It looks like this regression might’ve been introduced in OpenHistoricalMap/ohm-website@aa67d1c7d1ebec60eb5aa04e13bddc522e20ad45 for OpenHistoricalMap/ohm-website#173. Before that, we were aligned with the upstream refactoring from last year in openstreetmap/openstreetmap-website#3986. So this is the same root cause as #537 and https://github.com/OpenHistoricalMap/issues/issues/505#issuecomment-2036370793.

I think new visitors are very likely to go to the about page and then try to follow this link to the copyright page. Even if we don’t boil the oceans and solve this problem systematically as part of #735, we should at least align with what the code said before OpenHistoricalMap/ohm-website@aa67d1c7d1ebec60eb5aa04e13bddc522e20ad45.

1ec5 commented 1 week ago

As reported on Discord, this issue affects multiple links on the same page. See also the discussion in #893.