search

OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

“Resend html” instead of button to resend a confirmation e-mail #893

Open 1ec5 opened 1 month ago

1ec5 commented 1 month ago

I got a report from a user who reports that the button to resend a confirmation e-mail is broken in German:

image

IMG_0555

Reminds me of #537.

danrademacher commented 2 weeks ago

Another missing translation key from our copy of en.yml compared to upstream:

https://github.com/openstreetmap/openstreetmap-website/blob/abea45aa56c3360d7f309b9517cb7a7e3af99cc5/config/locales/en.yml#L1705

We know how to fix these one-off, but we never have gotten to a good solution for an overall sustainable solution AFAIK. Noted here https://github.com/OpenHistoricalMap/issues/issues/520

1ec5 commented 2 weeks ago

Maintaining this file would be sustainable, except for a bad merge that took place long ago and multiple attempts to cherry-pick strings that only made merges even messier: https://github.com/OpenHistoricalMap/issues/issues/505#issuecomment-2036370793.

erictheise commented 2 weeks ago

I'm happy to report that the daily continuous integration run of our overpass-turbo fork failed the other day, first time since July, alerting me to, among other things, the renaming of one key and the addition of a handful of new ones.

I think the approach I've taken will be an acceptable way forward for ohm-website once I replicate the process there.