OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

Add OHM basemaps to OSMCha #900

Open 1ec5 opened 3 weeks ago

1ec5 commented 3 weeks ago

By default, OSMCha overlays the selected changeset’s edited features atop a Mapbox Satellite Streets basemap. Under the Map Controls menu, there’s also an option to change the map style to some other OpenStreetMap-based map styles. This is fine for reviewing changes related to very recent features, but it can be very misleading when inspecting changes related to past features. For example, to someone unaware of this issue, this changeset might look incorrect, but it’s simply historic:

Mapbox Satellite Streets

OpenStreetMap Carto

We should add an option to show the OHM-based Historical and Railway styles. Similar to Overpass turbo, we can probably get away with an unfiltered map without a time slider, although a date filter option would go nicely in the Map Controls panel.

The style options are defined here in osmcha-frontend, which we might need to fork:

https://github.com/OSMCha/osmcha-frontend/blob/77ef6be09dbab738a2719a8d4bed7131b007244e/src/components/changeset/map_options.js#L16-L34 https://github.com/OSMCha/osmcha-frontend/blob/77ef6be09dbab738a2719a8d4bed7131b007244e/src/components/changeset/map_options.js#L59-L63

It would be a very minimal change, since the map is already a Mapbox GL JS map. Ideally we’d migrate it to MapLibre GL JS to ensure compatibility with the OHM styles, but it’s probably still compatible in practice.