OpenHistoricalMap / issues

File your issues here, regardless of repo until we get all our repos squared away; we don't want to miss anything.
Creative Commons Zero v1.0 Universal
19 stars 1 forks source link

Stylesheets hard-code organization names #902

Open 1ec5 opened 3 weeks ago

1ec5 commented 3 weeks ago

In the Historical stylesheet, the points_acra and points_oxfam symbol layers filter the buildings layer by many variants of the names “Acra” and ”Oxfam” in order to assign what appear to be two organization logos:

https://github.com/OpenHistoricalMap/map-styles/blob/0a3584f80897c31dfb075b18c3da121138df881b/main/main.json#L6058-L6114

Is this intentional? If so, we should make the matching less fragile by exposing operator:wikidata=* and brand:wikidata=* in the tiles and having these layers match on those fields instead. In OpenStreetMap, the name suggestion index ensures that Oxfam-operated facilities are tagged brand:wikidata=Q267941 or operator:wikidata=Q267941, depending on the POI type; I’d expect similar tagging in OHM. I don’t know what “Acra” refers to. Google Images comes up empty for this icon:

https://github.com/OpenHistoricalMap/map-styles/blob/0a3584f80897c31dfb075b18c3da121138df881b/main/poi/acra-18.svg

vknoppkewetzel commented 16 hours ago

hmm I suspect ACRA is similar to OXFAM and referencing something humanitarian aid related, but not positive... their logo isn't a tree (maybe it was once?) Associazione di Cooperazione Rurale in Africa e America Latina https://www.acra.it/ https://www.ewabelt.eu/acra-foundation also: https://www.acra-ssd.org/

hmm although. this maybe confirms my suspician here, in terms of associating it with humanitarian aid (Nathanial also said ??? lol): https://github.com/tilezen/vector-datasource/issues/1424

hot-osm.json referenced here also has ACRA and OXFAM next to each other --> https://github.com/openlayers/ol-mapbox-style/blob/main/test/fixtures/hot-osm/hot-osm.json


With all this said, I think we don't need this in main?