search

OpenHospitalityNetwork / fedi-trustroots

Next generation federated hospitality exchange platform
https://openHospitality.network
GNU Affero General Public License v3.0
23 stars 3 forks source link

Problem: Pull requests may go unnoticed #11

Closed weex closed 3 years ago

weex commented 3 years ago

To support smooth development, and per 2.4.15 of https://rfc.zeromq.org/spec/42/, Maintainers should merge correct pull requests rapidly, yet unless a maintainer is watching (being notified) for pull requests, they won't know about it, even if they are in the Matrix channel.

Potential solution: Setup a github action to send a message to the chat when anything pull request-related happens. This requires an access key for the channel be available to the github action.

aschrijver commented 3 years ago

It is weird that Github does not notify organization repo maintainers when PR's occur (not in the notification window, nor by email). I contacted support for that in the past. There may also be a GH Action to inform maintainers more directly (didn't check).

weex commented 3 years ago

Just opened a pull request and it failed to notify.

mariha commented 3 years ago

After GitHub docs about encrypted secrets:

Note: With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

Looks like that GH Action won't work with C4 flow based on forks.

@weex one thing that you can do is to Watch the repo, as you do for the one with webpage, then you'll get emails for all the activities.

Some other ideas:

  1. when creating a pr ask everyone to assign or mention you or other selected people
  2. add CODEOWNERS with maintainers team - everyone will be requested for review and email-notified
  3. add selected people (you) to CODEOWNERS
  4. set notifications with some other CI (quick search: Travis can notify matrix, CircleCi can notify irc or slack which can be bridged to matrix...)

I'd do either 2 or 4. As for me e-mail is good enough (in terms of timely feedback), we could consider auto-merge in the future in some cases, ex. when there was executable specification and all tests passed.

weex commented 3 years ago

I've set to watch for pull-requests and email is probably fine for me as well. I'm confused as to how PR notifications to Matrix work for any repo since pull requests are always created from a fork. I suppose OpenHospitalityNetwork/fedi-trustroots also being a fork can complicate? In any case, I'm satisfied with GH watching. Feel free to close.

chagai95 commented 3 years ago

A workaround could be to set a dedicated email for this and forward all the inbox to the matrix chat, should be easy to setup

mariha commented 3 years ago

I'm confused as to how PR notifications to Matrix work for any repo since pull requests are always created from a fork.

@weex it's possible to create PR from a branch. Many projects develop on public branches actually, rather then forks. It's more lightweight - doesn't make distinction of ownership that explicit though.

@chagai95 at this point I feel like effort/benefits is not worth it, feel free to do it if you'd like though!

weex commented 3 years ago

Currently, this leaves a red X on any PRs so it would be an improvement to remove the current integration.