OpenHospitalityNetwork / fedi-trustroots

Next generation federated hospitality exchange platform
https://openHospitality.network
GNU Affero General Public License v3.0
23 stars 3 forks source link

Secrets used in Travis build are committed to the repo #36

Open weex opened 2 years ago

weex commented 2 years ago

This doesn't seem secure to me, though perhaps there is a policy that only accepts requests from specific accounts on services like Travis.

Best to migrate those secrets into GitHub's secret store before setting up similar integrations for this project. I've created a Space called ohn-builds and Spaces API key in the OHN team but am not sure whether that should be added to the repository or environment for inclusion in .travis.yml.

nicksellen commented 2 years ago

Anything with the secure yaml key is encrypted, and safe to have in the repo. There is a Travis CLI that can be used to add encrypted secrets.