search

OpenHospitalityNetwork / fedi-trustroots

Next generation federated hospitality exchange platform
https://openHospitality.network
GNU Affero General Public License v3.0
23 stars 3 forks source link

First federation steps #80

Closed chagai95 closed 2 years ago

chagai95 commented 2 years ago

I disabled CORS and removed permission checks so these things have to be considered and tested to see what the implications are.

Also the colors are different than upstream.

I will try to show a better view when clicking on a federated dot but for now it is erroring

Part of #62

weex commented 2 years ago

What issue does removing CORS headers and permission checks solve?

chagai95 commented 2 years ago

Trying to use the api from a different origin fails because of CORS, and since we have no concept for data replication and there were checks to see if the user is logged in I removed those as well.

weex commented 2 years ago

Trying to use the api from a different origin fails because of CORS, and since we have no concept for data replication and there were checks to see if the user is logged in I removed those as well.

I don't really have a problem merging this once it's not a draft, but do consider making issues for these in case other solutions may be possible.

I can imagine someone in the future may look at the project and say "security! they're not even using CORS" and add it back, and if so fine. My feeling is another API testing method may let you supply the correct headers (e.g. Postman).

chagai95 commented 2 years ago

Yeah, more documentation would be a good idea.

mariha commented 2 years ago

I am going to merge it. It may not meet our quality standards but moves us forward in the right direction.

Kids are either clean or happy, I am thinking the same is true for developers and a foss community.

Instead of detailed PR reviews I'd do optimistic merge and post-merge review in order to close an issue. So we'll keep issues open until our functional and quality standards are met, but merge PRs quickly to maximize on contributors positive experience.

Over time we could add automated checks for things that we expect for each code change, like new tests to be added so that the change is protected from being broken in the future.