OpenHumans / archive-genevieve-201505

(Archived) Former attempt to create an open source tool for understanding the impact of genetic variants
MIT License
3 stars 4 forks source link

Add 23andme API import, and some code clean up #10

Closed madprime closed 9 years ago

madprime commented 10 years ago

This includes a file that has the reference positions for every 23andme position. It's large, but I'm storing it as text because future edits will be additional lines to that file (and you'll be able to use "diff" to see what's added). (Presumably no lines will disappear, because the 23andme API states that they won't break backward compatibility for the current data.)

Remember you'll need to update requirements.txt, and probably run migrate. (We no longer use "syncdb", it's now "migrate".) You'll also need to create the settings_local.py file (see new README instruction).

There's also a little code clean-up, although more is needed (what I did was mostly just tidying). To help improve our code, here's two things I think you should do:

  1. Use a live linter while you code. I recommend trying the "atom" editor (http://atom.io) and add the pylint linter extension. Atom is a new open source editor created by Github. I started using it over the summer and I'm pretty happy with it.
  2. Run pylint --load-plugins pylint_django filename on your code. Also, don't use a global pylint installation, use pip and virtualenv to have a local version. (Note that it's been added to the requirements for this project. I think I had to uninstall pylint globally for this to work. You need the local pylint install so it doesn't throw errors about all the other project-specific packages that aren't globally installed.)