search

OpenHumans / open-humans

Powering openhumans.org
https://www.openhumans.org/
MIT License
73 stars 22 forks source link

Failed 23andMe processing #371

Closed madprime closed 8 years ago

madprime commented 8 years ago

Reported by a user in Desk ticket 235.

madprime commented 8 years ago

User's data was a Zip archive. Data processing asserts that Zip archives must contain one and only one file (to be unambiguous), and this archive violated the assertion. This occurred because it was (presumably) constructed on OSX and contained the __MACOSX directory. To avoid this issue, we should ignore this directory (if it exists) when counting and processing a Zip archive.

madprime commented 8 years ago

Fixed by https://github.com/PersonalGenomesOrg/open-humans-data-processing/commit/ee32f78e5668f1776e6687ec5f2e0494a1efe8a5

beaugunderson commented 8 years ago

@madprime I wonder if it's worth keeping a list of 'extraneous' files, like .DS_Store that could end up in a zip file?

madprime commented 8 years ago

@beaugunderson Oh, is that another one? I should get a reference list of hidden cruft directories and files OSX automatically adds that's invisible to OSX users. :(