search

OpenHydrology / StatisticalFloodEstimationTool

wxpython based tool for assessing flood flows using current UK FEH methods
GNU General Public License v3.0
2 stars 1 forks source link

urbext #25

Open neilnutt opened 9 years ago

neilnutt commented 9 years ago

Why do we have the get_urbext and set_urbext methods in Descriptors? Surely it is either urbext2000 or urbext1990, they are different things and I think we should be clear about what they are? I find the use of urbext a bit ambiguous.

faph commented 9 years ago

See http://open-hydrology.readthedocs.org/projects/floodestimation/en/latest/entities.html#floodestimation.entities.Descriptors.urbext . It's an alias for urbext2000.

It's an python property (https://docs.python.org/3.3/library/functions.html?highlight=property#property). So you can either use urbext or urbext2000. The idea being that if code uses urbext it only needs to be updated in one place to refer to the latest urbext parameter. But this may be not very useful if the actual definition of the parameter changes. Let me know if you want it completely stripped out.

neilnutt commented 9 years ago

I feel that this is a bit unnecessary, in theory at least urbext1990 and urbext2000 are not interchangeable and it is a bit presumptious that any new urbanisation parameter would be compariable. Looking at it the other way does it not risk an error in the future when an old method uses a different urbanisation parameter?

faph commented 9 years ago

Agree. Will remove urbext.