search

OpenHydrology / floodestimation

Python flood estimation library
GNU General Public License v3.0
6 stars 2 forks source link

1999 QMED method doesnt do donor adjustment #6

Open faph opened 9 years ago

faph commented 9 years ago

The 1999 QMED analysis doesn't implement a donor adjustment procedure.

Do we really need this as this method has been superseded by the FEH 2008 updates? Can we not simply drop support for the 1999 method?

neilnutt commented 9 years ago

Okay okay, I see you really don't want a donor adjustment for the 1999 method, though surely it was included as updating using an 'analogue'. Still want to be able to do a qmed by area with local donors though. On 24 Dec 2014 12:23, "Florenz A. P. Hollebrandse" notifications@github.com wrote:

The 1999 QMED analysis doesn't implement a donor adjustment procedure.

Do we really need this as this method has been superseded by the FEH 2008 updates? Can we not simply drop support for the 1999 method?

— Reply to this email directly or view it on GitHub https://github.com/OpenHydrology/floodestimation/issues/6.

faph commented 9 years ago

We can. It's more of a question how much time do you want to spend on a method that has been superseded?

Still want to be able to do a qmed by area with local donors though.

Don't quite understand. Is this a separate approach? Can you open a new issue if needed?

neilnutt commented 9 years ago

Updating for 1999 analogue is quick to implement, it is just direct transfer of the error no funny distance weight. I guess what I'm saying is that the donor correction should be flexible to the qmed method used, allowing easy flexibility for outdated methods demonstrates future flexibly for the hopefully easy inclusion of the next new method.

The area thing is separate to qmed 1999, needs its own item. On 24 Dec 2014 18:28, "Florenz A. P. Hollebrandse" notifications@github.com wrote:

We can. It's more of a question how much time do you want to spend on a method that has been superseded?

Still want to be able to do a qmed by area with local donors though.

Don't quite understand. Is this a separate approach? Can you open a new issue if needed?

— Reply to this email directly or view it on GitHub https://github.com/OpenHydrology/floodestimation/issues/6#issuecomment-68068323 .

faph commented 9 years ago

I'd suggest making this flexibility a lower priority. Pick and mix on QMED and donor methods is not really good practice imho.