OpenICC / xcalib

Load 'vcgt'-tag of ICC profiles to X-server and MS-Windows. Works on calibration stage, which can be a precondition for display ICC color conversions.
Other
67 stars 12 forks source link

Update xcalib.c #1

Closed rthardy closed 6 years ago

rthardy commented 6 years ago

Tab use (control character) was inconsistent and unnecessary, and causes warnings in plotutils, e.g.; xcalib -p -a | grep ^[0-9] | graph -a -T X -x 0 3071 -y 0 65535 -m 0 -X "$(xcalib -l -a | tail -n 1)"

rthardy commented 6 years ago

So...some questions if I could:

I've been thinking about more extensive changes:

The reason for that last is modifying an inverted ramp makes as much sense to me as modifying any other ramp. It happens a quarter of the time when I run the following script

#!/bin/bash

if test -f ~/.inverted-display; then
    if test -f ~/.altered-display; then
        xcalib -c;                    #this is a normal display
        rm ~/.inverted-display ~/.altered-display;
    else
        xcalib -co 66 -a;             #nighttime away from city lights
        touch ~/.altered-display;
    fi
else
    if test -f ~/.altered-display; then
        xcalib -c;                    #nighttime inverted display
        xcalib -red 0.7 0 100 -green 0.7 0 84 -blue 0.7 0 67 -i -a;
        mv ~/.altered-display ~/.inverted-display;
    else
        xcalib -gc 2.2 -a;            #high gamma for incident sunlight
        touch ~/.altered-display;
    fi;
fi;

I've been using some version of that script for years, now.

beku commented 6 years ago

I was just waiting before a merge to give you time for finishing.

yes, he git repository is the base for the openSUSE and some other distro packages.

The tabs and wording changes appears fine to me.

beku commented 6 years ago

@rthardy can you please turn your other points into issues? Then we can comment on each separately. Thanks