OpenINF / docker-fisher

๐Ÿณ Dockerfiles built for plug-and-play Fish ๐ŸŸ shell components powered by the scorching fast Fisher ๐Ÿ”ฅ plugin manager
https://github.com/OpenINF/docker-fisher?tab=readme-ov-file#readme
3 stars 1 forks source link

๐Ÿณโœจ๏ผša Debian-Fisher-Gallium container collab (take 2) #36

Closed DerekNonGeneric closed 9 months ago

DerekNonGeneric commented 9 months ago

Pull Request Purpose

Make a selection on the purpose(s) of your changes.

This PR contains the following:

Testing

Have you included any tests in your submission?

Breaking Changes

Have you modified any aspect public API surface (i.e., caused breakage)?

Description

A concise recap summarily detailing what all are the changes being made.

we are in the communication blackout period, but once it's possible, please confirm we are all ready for takeoff on our Debian-based Docker container powered by Fisher plugins

/cc @jorgebucaran @OpenINF/ateamgrimesai

List of any relevant issue numbers:

DerekNonGeneric commented 9 months ago

i will be landing https://github.com/OpenINF/docker-fisher/pull/32 very, very soon since this task seems dependent on its readiness

OpenINFbot commented 9 months ago

@DerekNonGeneric, well done!

here is a summary of what remains from the previous endeavor:

DerekNonGeneric commented 9 months ago

FYI: ๐Ÿ”— https://containers.dev/implementors/json_reference/#min-host-reqs

:link: https://code.visualstudio.com/docs/setup/linux#_rhel-fedora-and-centos-based-distributions

i am going to be installing VS Code now too (recommend the same)

am looking into how, but i have no objection to vscodium:

socket-security[bot] commented 9 months ago

New and removed dependencies detected. Learn more about Socket for GitHub โ†—๏ธŽ

Package New capabilities Transitives Size Publisher
npm/@openinf/util-text@1.1.2 Transitive: environment, eval, shell +18 859 kB dereknongeneric
npm/zx@7.2.3 environment, filesystem Transitive: network, shell +56 15 MB google-wombot

๐Ÿšฎ Removed packages: npm/@yarnpkg/shell@4.0.0, npm/cspell@8.3.2, npm/editorconfig-checker@5.1.4, npm/remark-cli@12.0.0, npm/remark-validate-links@13.0.0, npm/stylelint-config-recess-order@4.6.0, npm/stylelint-config-standard-scss@13.0.0, npm/stylelint@16.2.1

View full reportโ†—๏ธŽ

socket-security[bot] commented 9 months ago

๐Ÿšจ Potential security issues detected. Learn more about Socket for GitHub โ†—๏ธŽ

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Protestware/Troll package npm/es5-ext@0.10.62
  • Note: This package prints a protestware console message on install regarding Ukraine for users with Russian language locale
Install scripts npm/es5-ext@0.10.62
  • Install script: postinstall
  • Source: node -e "try{require('./_postinstall')}catch(e){}" || exit 0

View full reportโ†—๏ธŽ

Next steps

What is protestware?

This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function.

Consider that consuming this package my come along with functionality unrelated to its primary purpose.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/es5-ext@0.10.62
DerekNonGeneric commented 9 months ago

i am going to have to pull out some of this into a separate pr…

DerekNonGeneric commented 9 months ago

want to merge this asap for obvious reasons…

also is getting too large to review already

DerekNonGeneric commented 9 months ago

ok, really sorry, but we'll be needing a re-take