OpenINF / openinf-util-text

Cross-platform terminal-friendly text utilities
https://github.com/OpenINF/openinf-util-text#readme
Other
4 stars 1 forks source link

[feature request] add new “cyan” color function #31

Open DerekNonGeneric opened 2 years ago

DerekNonGeneric commented 2 years ago

The color “cyan” is preferable to “blue” in most cases especially since the default background color for the PowerShell app on Windows Server 2022 Standard (and many other previous version) is a very similar shade of blue making any foreground text color difficult to read as you can see in the following image.

image

Similar findings elsewhere:


I would prefer to call this function cyanify seeing as how the word “cyanize” already exists and seemingly has a completely different meaning.

Refs: https://www.merriam-webster.com/dictionary/cyanize

ghost commented 1 year ago

Hi @DerekNonGeneric,

I have added this feature, and same as last time, excluded the generated intex.js file. We have the same issue, that the CI code guidelines differ from the actual code style already in the repo.

Other than these, the feature works as expected

DerekNonGeneric commented 1 year ago

Hey @dadolhay, good work! I see now what the issue is wrt to the CI code guidelines failing — i am going to see about getting that resolved right away (it doesn't look too difficult).

ghost commented 1 year ago

@DerekNonGeneric Sounds good! I also suggest adding prettier to the project. With the appropriate config, it should handle the code formatting automatically and save some of the effort

DerekNonGeneric commented 1 year ago

Just so that i don't forget about this, it was left undocumented and we still need to have that suggestion taken in this repo…