search

OpenIPC / divinus

Multi-platform open source streamer
https://openipc.org
MIT License
17 stars 10 forks source link

__connection_reset(),session_id is zero #20

Open Mike199201 opened 1 week ago

Mike199201 commented 1 week ago

hello： Additionally, there may be an issue with the code at __connection_reset(). Assigning ctx to 0 and passing it as a parameter to __get_random_llu means that p->session_id will be 0, which is not a unique value for session_id. image

wberube commented 1 week ago

Hi again,

Compared to the previous issue, I have to admit this is probably not very compilant with the RFC standards, the ideal corrective would be to carry the timestamp for both samples when ingesting them from the encoder callback functions, to ensure they get their right presentation time.

I can definitely find some room on my roadmap for this particular timestamp issue, whereas the session ID isn't a big deal right now in my opinion because the RTSP server should NEVER be exposed to the Internet without at least having authentication.

For a business environment, I would most assuredly provide my IP cameras their own subnet just like it used to be done with telephony before SIPS and SRTP became mainstream.