[ipctool spidetect] always calls i2cdetect

[RoboSchmied]

edited: short summary of the problem see next comment.

When I run the command ipctool spidetect I get the same results as running ipctool i2cdetect:

root@openipc-gk7205v210:/tmp# ipctool i2cdetect
       0  1  2  3  4  5  6  7   8  9  a  b  c  d  e  f
    : xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  10: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  20: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  30: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  40: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  50: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  60: 60 61 xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  70: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  80: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  90: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  a0: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  b0: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  c0: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  d0: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  e0: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  f0: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx 

root@openipc-gk7205v210:/tmp# ./ipctool spidetect
       0  1  2  3  4  5  6  7   8  9  a  b  c  d  e  f
    : xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  10: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  20: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  30: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  40: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  50: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  60: 60 61 xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  70: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  80: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  90: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  a0: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  b0: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  c0: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  d0: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  e0: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx xx  |  
  f0: xx xx xx xx xx xx xx xx  xx xx xx xx xx xx xx 

code problem

    } else if (!strcmp(argv[0] + 3, "detect")) {
            return i2cdetect(argc - optind, argv + optind, script_mode);
    }

• The i2c_mode is not regarded as done here:

  } else if (!strcmp(argv[0] + 3, "dump")) {
      if (i2c_mode)
          return i2cdump(argc - optind, argv + optind, script_mode);
      else
          return spidump(argc - optind, argv + optind, script_mode);

• And there is no spidetect function in i2cspi.c.

Solution 1 (if spidetect should be implemented)

• regard i2c_mode:

  
  } else if (!strcmp(argv[0] + 3, "detect")) {

• if (i2c_mode) return i2cdetect(argc - optind, argv + optind, script_mode);
• else
• return spidetect(argc - optind, argv + optind, script_mode);

  
  and:

ToDo 1

• create a spidetect function.

Solution 2 (if spidetect is not needed)

• regard i2c_mode

  
  } else if (!strcmp(argv[0] + 3, "detect")) {

• if (i2c_mode) return i2cdetect(argc - optind, argv + optind, script_mode);

  
  [in i2cspi.c](https://github.com/OpenIPC/ipctool/blob/cc2849e8d2cafe0ad7b97f989ea3e2263eaf6e7f/src/i2cspi.c#L302C1-L304C6)

[RoboSchmied]

Oh, I now saw that spidetect is not existing / supported at all.

https://github.com/OpenIPC/ipctool/blob/cc2849e8d2cafe0ad7b97f989ea3e2263eaf6e7f/src/main.c#L70C1-L107C2

It is only (accidentally?) accepted as ipctool command so I thought it was existing.
:D