search

OpenIPC / webui

OpenIPC web interface.
https://openipc.org
MIT License
46 stars 41 forks source link

Majestic night mode settings allow only one illumination pin #265

Open plush opened 9 months ago

plush commented 9 months ago

The illumination for night mode can be configured in two places:

On the "Illumination" settings page (/var/www/cgi-bin/config-light.cgi), separate GPIO pins can be set for 850 nm and 940 nm IR LEDs, and both are saved to the firmware environment as ir850_led_pin and ir940_led_pin. However, only one of the pins is written to .nightMode.backlightPin and this is the only variable/ pin that the Majestic settings "Night Mode" tab can deal with.

Having support for two LED pins in some parts of the system and only one in others leads to inconsistencies: On the preview page, you can toggle both LEDs (even separately). But the /usr/sbin/irled.sh script will only toggle the one LED stored in Majestic settings.

It would be great to take into account both LEDs throughout and turn both of them on/off as night mode is toggled.

flyrouter commented 9 months ago

Good afternoon, thank you for your interest in the project. These are experimental sections and I think in the near future decisions will be made on how to manage them.