search

OpenIdentityPlatform / OpenAM-JEE-Agents

OpenAM Java EE Policy Agents is an OpenAM add-on component that functions as a Policy Enforcement Point (PEP) for applications deployed on a Java EE-based servlet container or application server. The policy agent protects web-based applications and implements single sign-on (SSO) capabilities for the applications deployed in the container.
Other
6 stars 13 forks source link

fix build issue #20

Closed maximthomas closed 12 months ago

maximthomas commented 12 months ago

fix build issue #19, rename artifacts to opendientiyplatform and remove OpenAM submodule

lscorcia commented 12 months ago

Would it be possible to build with Java 11? I tried with your PR and it seems to fail with "version 1.5 no longer supported" in project jee-agents-sdk . It works with Java 8.

Thank you!

EDIT: It is enough to just add those two lines to the main pom.xml:

<properties>
  ...
  <maven.compiler.source>1.8</maven.compiler.source>
  <maven.compiler.target>1.8</maven.compiler.target>
</properties>

The build then works on Java11 too.

lscorcia commented 12 months ago

Additional comment - the newly generated package does not contain the necessary dependencies, so it does not install:

EDIT: The issue is caused by jee-agents-distribution/jee-agents-distribution-tomcat-v6/src/main/assembly/tomcat-v6_KitAssembly_Descriptor.xml - it still uses org.forgerock.openam instead of org.openidentityplatform.openam.

lscorcia commented 12 months ago

Unfortunately even that isn't enough. Now it installs correctly, but it errors at startup. Missing/moved dependency?

14-Sep-2023 17:30:40.080 SEVERE [main] org.apache.tomcat.util.digester.Digester.startElement Begin event threw exception java.lang.NoClassDefFoundError: org/forgerock/openam/sdk/org/forgerock/util/time/TimeService at org.forgerock.openam.utils.Time.(Time.java:48) at org.forgerock.openam.utils.Time.(Time.java:43) at com.iplanet.am.util.SystemProperties$PropertiesHolder.(SystemProperties.java:751) at com.iplanet.am.util.SystemProperties.(SystemProperties.java:135) at com.sun.identity.agents.arch.AgentConfiguration.bootStrapClientConfiguration(AgentConfiguration.java:708) at com.sun.identity.agents.arch.AgentConfiguration.initializeConfiguration(AgentConfiguration.java:1147) at com.sun.identity.agents.arch.AgentConfiguration.(AgentConfiguration.java:1586) at com.sun.identity.agents.arch.Manager.(Manager.java:675) at com.sun.identity.agents.tomcat.v6.AmTomcatRealm.(AmTomcatRealm.java:67)

maximthomas commented 12 months ago

@lscorcia hi, you can check the latest commit in the PR