search

OpenImaging / miqa-phase1

A web application for medical imaging quality assurance
MIT License
20 stars 8 forks source link

Fix issue with screenshot size #114

Open scottwittenburg opened 3 years ago

scottwittenburg commented 3 years ago

Currently just fixes the captured screenshot size at 512x512, but could be extended in the future to allow the user to specify an arbitrary size. Depends on this PR getting merged into vtk.js, then we can bump the version we depend on here.

Fixes #99

jimklo commented 3 years ago

@scottwittenburg I've pulled and tried this on our integration environment. I've tried resizing my browser and taking various screen shots, and it's still sending images larger than 512x512 px.

scottwittenburg commented 3 years ago

@jimklo That's because it depends on a change in vtk.js which isn't merged yet. As I mentioned in the description, we need that to get merged and generate a new version, then we can bump our dependency on vtk.js to pick it up. I changed this to a draft.

aashish24 commented 3 years ago

@dchiquito could you look over at this issue with help from @scottwittenburg and @dzenanz

jimklo commented 3 years ago

The screen shot issue is somewhat fixed. 512x512 max proportions seems fine. The problem we seem is that there is too much black, and the actual MRI image is very small and low resolution in comparison to the image size embedded in the email. Image sample from 4K browser

The browser size and host resolution seems to also still play a variable, as when I took snapshots using my iPad, the scan better fills the 512x512 box, however the image resolution seems low the size. Image Sample from iPad Pro 12.9"