OpenImporter / openimporter

Development workspace for the open Importer engine.
BSD 3-Clause "New" or "Revised" License
21 stars 14 forks source link

Simple HTML not converted from SMF 2.0.x #103

Closed Frenzie closed 5 years ago

Frenzie commented 8 years ago

In SMF, simple HTML was stored like:

<img src="whatever">

In Elk, that has become:

<img src="whatever">

This should preferably be converted during the import process.

emanuele45 commented 8 years ago

I guess some overzealousness in htmlspecialchar'ring the body of the messages. :angel:

Vekseid commented 5 years ago

This is the wrong way around from what is occurring.

The converter changes

<img src="whatever">

into

<img src="whatever">

And Elkarte doesn't understand the result.

However, at least as of 1.1 " still gets converted into & quot; for the database, and ' to &# 039;. It's still generating

<br />

On newlines.

The fixTexts method in the SMF common source is accordingly unnecessary and should be removed. It should only be a thing if/when Elkarte's handling of these things actually changes.

Even then, this should not be done on a row-by-row basis, but rather with a query that alters the database en masse, which is very quick and runs in seconds even for multi-million row conversions.