search

OpenImporter / openimporter

Development workspace for the open Importer engine.
BSD 3-Clause "New" or "Revised" License
21 stars 14 forks source link

Some kind of "versions" for Sources/Destinations? #78

Open margarett opened 9 years ago

margarett commented 9 years ago

Something that came to my mind... I am now starting to work in a new "Source" --> MyBB 1.8 And I am already working in a new "Destination" --> SMF 2.0 (2.1 should follow)

The thing is: When new "core" modifications are made, chances are that some "Importers" (more generally) get either broken or not completely functional. Eg, as of now (none was actually tested, just passed through the "Sources": Viscacha presents a "notice" in the second screen SEO Boards is broken "Class not found"

This problem has the potential to grow a lot, as I intend to add several Sources (once I get the hang of it :tongue: )

Maybe we should have some kind of "package version"/"Importer version" thing?

emanuele45 commented 9 years ago

I think when you talk about "core" modification you mean the structure of skeleton.yml (I think, if it is not then I mixed up things LOL).

Ideal world

Each and every source and destination has one or more automated tests that verifies the output and input (respectively) is compliant with the skeleton structure and doesn't produce any warning/error.

Real world

Well, this is a development version and there are no such tests, so breakages are the rule. xD

On the script versions, at the moment I tried to keep the versions as part of the class name (e.g. SMF2_0). Having the "idea" to follow (somehow) PSR-4 autoloading standards, the class should be in a file named SMF2_0.php. SeoBoards is broken because class name and file name do not match. As a "coding standard", I think class and file names should be the same, so in case of SeoBoards 1.1 we should have:

My fault, the naming is broken. :angel: That's the reason of the class not found error. Viscacha... I have no idea, I have not tested it in a while... :blush:

margarett commented 9 years ago

Well, not just the skeleton... Pretty much everything which is not "destinations"/"sources".

About the automated tests... Dunno, I've seen so many outcomes of the same converter that I'm not sure I believe in these tests...

BTW: (completely OT): I was just asked to convert a Proboards/forums.net database dump. I'm going head first in integrating it in OI. Wish me luck :tongue:

emanuele45 commented 9 years ago

Well, not just the skeleton... Pretty much everything which is not "destinations"/"sources".

Then I'm a bit lost. LOL I'll re-read the issue when my mind clears up a bit. :partly_sunny:

About the automated tests... Dunno, I've seen so many outcomes of the same converter that I'm not sure I believe in these tests...

Considering just just a couple of methods of a couple of sources are tested, it doesn't really surprise me. :P Tests are not written yet, they have to. As I said, 2.0 is not really anything close to a "beta", it's still in a serious refactoring/development status and breakages are really the norm in this phase. I think I rewrote half of my code several times.

BTW: (completely OT): I was just asked to convert a Proboards/forums.net database dump. I'm going head first in integrating it in OI. Wish me luck :tongue:

Good luck! :dancers: