search

OpenIntelWireless / HeliPort

Intel Wi-Fi Client for itlwm
https://OpenIntelWireless.github.io/HeliPort
BSD 3-Clause "New" or "Revised" License
1.09k stars 122 forks source link

[Feature Request] Show scan results immediately when Wi-Fi is turned back on #107

Closed mackonsti closed 4 years ago

mackonsti commented 4 years ago

Is your feature request related to a problem? Please describe. If we turn OFF Wi-Fi via HeliPort and back ON, there's no indicator that a scan is being done; the drop-down list is empty. It takes 5 seconds or more to show nearby SSIDs. Could be expected behaviour, but the macOS rotating icon would be welcome so users aren't puzzled (or anxious)

Describe the solution you'd like Add the macOS standard animation icon (rotating) that would indicate an SSID scan is taking place. From a UI perspective, add this next to the text label Turn WiFi Off would make sense and would be more visible. Turn animation off, when SSID scan is reported as complete.

Activity (above sample is from another window, I just wanted to find out the reference animation, obviously one rotating icon!)

Describe alternatives you've considered While scanning SSIDs a grey menu item in the drop-down menu could also state "Scanning Networks..." instead. But that's also needed to be coded. Connected Add "Scanning Networks..." label as a disabled, greyed-out element UNDER "Turn WiFi Off" and ABOVE "Join Other Network..." with separator lines like "WiFi: Connected" on top. The space occupied by grey "Scanning Networks..." would then be replaced by the list of scanned SSIDs.

Additional context Just helpful to those who click on the icon and may be wondering whatever happened to the SSIDs.

williambj1 commented 4 years ago

Actually we already have "Wi-Fi: Looking for Networks" when itlwm is scanning. In fact, I don't think we need to add any extra animations since Apple doesn't have them as well.

We might need to further optimize when should HeliPort get the scan results. Based on my understanding, itlwm should have a valid scan result when the adapter is turned back on and the Wi-Fi is connected, results are not shown because HeliPort was delayed.

mackonsti commented 4 years ago

Thanks @williambj1 but the reason for posting this ticket is that there was no sign of such information or status display on HeliPort. Could it be that HeliPort wasn't connected to itlmw? I have not seen such "Wi-Fi: Looking for Networks" message on the drop-down menu.

williambj1 commented 4 years ago

"Wi-Fi: Looking for Networks" only appears when itlwm hasn't connected to a network. Background scanning was previously disabled so we didn't implement this when there is a connected network. This would be a Todo for our next version. (we're going to announce our first release within a few hours :) )

mackonsti commented 4 years ago

Thanks and congratulations for your announcement! In any case, a visual status of a SSID scan being done, would be welcome. Right now, me personally I can't see anything if switching from OFF state to ON state the driver via HeliPort :-) Thank you for your consideration and your great work.

williambj1 commented 4 years ago

The network list appearance delay should be fixed in the latest master, now it appears instantly.