search

OpenIntelWireless / HeliPort

Intel Wi-Fi Client for itlwm
https://OpenIntelWireless.github.io/HeliPort
BSD 3-Clause "New" or "Revised" License
1.12k stars 122 forks source link

error: SwiftLint not installed, download from https://github.com/realm/SwiftLint #121

Closed ProfDrLuigi closed 4 years ago

ProfDrLuigi commented 4 years ago

If I try to compile I get these error above.

ErrorErrorError commented 4 years ago

You need to install SwiftLint on your system before you can compile HeliPort. You can follow the link it shows you to install SwiftLint.

ProfDrLuigi commented 4 years ago

Yes I know. I put it in "Podfile" and installed it. But ... error.

grafik grafik grafik

ProfDrLuigi commented 4 years ago

Yes I did. have a look at my Screenshots above. I compiled HeliPort every day again. But this time it stucks.

ErrorErrorError commented 4 years ago

Yes I did. have a look at my Screenshots above. I compiled HeliPort every day again. But this time it stucks.

Yup sorry I didn't see that picture until after I sent the previous message. There hasn't been anything that changed in HeliPort project with SwiftLint as far as I know. I used brew install SwiftLint methods so I can't really say as to why the pods aren't working, well in this case SwiftLint.

If you want you could try the brew method but HeliPort hasn't really changed anything regarding to scripts and SwiftLint.

ProfDrLuigi commented 4 years ago

brew install did the trick. But I don´t understand why it was working the days before and now (nothing is changed) it stucks. But ok ... Problem solved. :)

Goshin commented 4 years ago

SwiftLint should be installed as a global CLI tool via brew, otherwise, you need to add the executable path of the pod module into your PATH variable.

ErrorErrorError commented 4 years ago

SwiftLint should be installed as a global CLI tool via brew, otherwise, you need to add the executable path of the pod module into your PATH variable.

It could also be included in Podfile via pod 'SwiftLint' since now the latest master has a script that checks if SwiftLint is installed via CocoaPods, however I am not sure which would be the most recommended way if having in the command line or just for the project itself via CocoaPods.

Goshin commented 4 years ago

It could also be included in Podfile via pod 'SwiftLint' since now the latest master has a script that checks if SwiftLint is installed via CocoaPods,

sry but I don't see the check script?

ErrorErrorError commented 4 years ago

sry but I don't see the check script?

if which "${PODS_ROOT}/SwiftLint/swiftlint" >/dev/null; then 
    ${PODS_ROOT}/SwiftLint/swiftlint
elif which swiftlint >/dev/null; then
    swiftlint
else
  echo "warning: SwiftLint not installed, download from https://github.com/realm/SwiftLint"
fi

This script is in the latest commit https://github.com/OpenIntelWireless/HeliPort/commit/0222faeafe01d9af83baf1d54ac771c197859b9c.

You can find it here: Screen Shot 2020-07-21 at 2 32 47 AM

However it is not something you have to add, you can still use brew install swiftlint, it's just another option since you have to invoke pod install anyways to download the other dependencies.

Goshin commented 4 years ago

oops I didn't notice the latest commit, so it should fix the issue.

williambj1 commented 4 years ago

:)