OpenIntelWireless / HeliPort

Intel Wi-Fi Client for itlwm
https://OpenIntelWireless.github.io/HeliPort
BSD 3-Clause "New" or "Revised" License
1.12k stars 122 forks source link

Added functionality to keep Wifi state after reboot/wake #184

Closed undefs closed 4 years ago

undefs commented 4 years ago

Issue As itlwm faq section described, Wifi initialization happens before Heliport launches. So, even if user manually turned it off, it still turn back on itself after every reboot/wake. It's tiring to turn it off every single time.

Solution I have created a solution to get ride of this problem. My implantation is simple, a preference Key to store the state, check whether the Wifi State has changed itself without user interaction and set it back to user defined state.

Note I didn't find any standard rules about coding style in docs. And there was no implementation for storing default preference, so I had to do it directly. Feel free to change.

williambj1 commented 4 years ago

Some people quit HeliPort after they've connected to their network; others even don't use HeliPort. If HeliPort is not running, your implementation will not work anymore. So it doesn't make sense to implement this feature in userspace.

https://openintelwireless.github.io/itlwm/FAQ.html#why-does-my-adaptor-turn-back-on-after-a-sleep-wake-cycle

Thank you for your contribution but sorry we won't merge this.

undefs commented 4 years ago

@williambj1 I understand. but what about those who use Heliport all the time. whoever won't use, it won't hurt them anyway. I know it's more of a itlwm side implementation. Since they are not implementing such feature, it will be good to have this option in Heliport. Anyway, it won't have to be my implementation. I just wish there is an option for this, either in itlwm or in Heliport. thanks.

williambj1 commented 4 years ago

@NeutralBit I understand your feeling of having such a feature and I also agree that it makes quite a lot of sense to have such a feature. However, it really should be done on itlwm's side as it provides a much better experience.

It won't be hard to do so in itlwm using NVRAM or Device Properties, I will create a dedicated issue on itlwm's repo and discuss this with @zxystd. Thanks.

undefs commented 4 years ago

Thank you.