search

OpenIntelWireless / HeliPort

Intel Wi-Fi Client for itlwm
https://OpenIntelWireless.github.io/HeliPort
BSD 3-Clause "New" or "Revised" License
1.09k stars 123 forks source link

Add swiftlint workflow for pull requests #215

Closed Cyberbeni closed 3 years ago

Cyberbeni commented 3 years ago

Push on master trigger is required because of caching security restrictions, other branches can use the cache from the default branch but not from each other.

williambj1 commented 3 years ago

xcodebuild will run SwiftLint during the build process, I believe it is redundant to run a dedicated workflow for lint. Please correct me if I am wrong.

https://github.com/OpenIntelWireless/HeliPort/blob/059e3113649e42a85e2204b44ce2f3e0f7a742a5/.github/workflows/main.yml#L5 https://github.com/OpenIntelWireless/HeliPort/blob/059e3113649e42a85e2204b44ce2f3e0f7a742a5/.github/workflows/main.yml#L39 https://github.com/OpenIntelWireless/HeliPort/blob/059e3113649e42a85e2204b44ce2f3e0f7a742a5/HeliPort.xcodeproj/project.pbxproj#L401

Cyberbeni commented 3 years ago

Those don't show up in the GH Workflow logs. There are currently 28 SwiftLint violations which have been getting ignored.

Cyberbeni commented 3 years ago

You could just delete the SwiftLint build phase and swiftlint.yml if you just want to ignore it.