search

OpenIntelWireless / HeliPort

Intel Wi-Fi Client for itlwm
https://OpenIntelWireless.github.io/HeliPort
BSD 3-Clause "New" or "Revised" License
1.12k stars 122 forks source link

[Bug] More StatusMenu glitches #29

Closed williambj1 closed 4 years ago

williambj1 commented 4 years ago

Describe the bug

  1. WiFiMenuItemView shows duplicated items with different fonts
  2. Long SSIDs (e.g. From wireless projectors/printers) will be wrapped

To Reproduce Steps to reproduce the behavior:

  1. Scan SSIDs for a while
  2. Connect to your Wi-Fi
  3. Open the menu again
  4. Wait for a while

Expected behavior A clear and concise description of what you expected to happen. No duplications, no line wraps

Screenshots If applicable, add screenshots to help explain your problem.

image

Environment (please complete the following information):

Additional context This issue existed for quite a long time.

ErrorErrorError commented 4 years ago

no line wraps

So the expected behavior of StatusMenu is to expand the width of the whole view correct? I actually had mine working like that but I might of deleted that code trying to figure out the issue with the different widths of WiFiMenuItemView.

williambj1 commented 4 years ago

So the expected behavior of StatusMenu is to expand the width of the whole view correct?

Yes, that's how Apple's app behaves, I've verified this on a MacBook Pro.

ErrorErrorError commented 4 years ago

Sorry for the multiple references, I thought I already removed the reference from commit to stop referencing on every squash.

Goshin commented 4 years ago

Fixed in https://github.com/OpenIntelWireless/HeliPort/commit/1cf4020f946372e574a3782f3eac76b47a9c1cdd and https://github.com/OpenIntelWireless/HeliPort/commit/bcfccca7c9793be6887725fca3e340f880cc124c