OpenIntelWireless / itlwm

Intel Wi-Fi Drivers for macOS
https://OpenIntelWireless.github.io/itlwm/
GNU General Public License v2.0
6.94k stars 667 forks source link

iwx: Status Led Support #894

Open hectorgrom opened 1 year ago

hectorgrom commented 1 year ago

Hello everybody First of all, I would like to congratulate the team for the wonderful work done, you are all to be congratulated... I don't come to report a bug, just a suggestion, which maybe went unnoticed, just as a complement to the wonderful work you guys are doing... Due to the support offered by the project, I purchased a compatible AX210 wifi card from our Chinese brothers "https://tinyurl.com/2xyeucz8"... Works perfectly, both WIFI and Bluetooth... However, just as a cosmetic, the card has an activity "led", which works on windows and linux, however, on Mac, using your driver, it does not work, maybe it is something simple to implement, or not, I would just like to leave my suggestion for the future implementation of this feature... Not that it's fundamental, it's working perfectly the way it is, but, if possible, it would be perfect...

Grateful

Congratulations.....

zxystd commented 1 year ago

Maybe I can try to implement this feature, would you mind help to testing?

hectorgrom commented 1 year ago

Of course not, I would be happy to help .... you can count on me .... :)

zxystd commented 1 year ago

@hectorgrom What's the macOS version you are using? I have made some changes, led may be work.

hectorgrom commented 1 year ago

hello .... I use Monterey .... waiting for the final version of Sonoma to migrate to the latest system ....

zxystd commented 1 year ago

Monterey.zip You can test this one, may have a LED working, although it is not behaves the same with Windows/Linux.

hectorgrom commented 1 year ago

I tested the file (clover/kexts/12), it works like the normal version, the wifi works normally, however, without an activity "led"....

zxystd commented 1 year ago

Monterey.zip I forgot something, try this one.

hectorgrom commented 1 year ago

nope not yet.... :(

hectorgrom commented 1 year ago

Just to show you how it works on windows, I'm turning the WIFI on and off, I just can't say for sure if the led corresponds to "activity" or just "status"...

https://github.com/OpenIntelWireless/itlwm/assets/61702551/19c858b4-c3c8-4f6d-ac6b-7ff8600aa2ba

zxystd commented 1 year ago

Just to show you how it works on windows, I'm turning the WIFI on and off, I just can't say for sure if the led corresponds to "activity" or just "status"...

Does the LED working on Linux?

hectorgrom commented 1 year ago

Hi.... Yes, it works the same on Windows 11 and Linux (Ubuntu 22.04.2 LTS)