OpenJobDescription / openjd-adaptor-runtime-for-python

A python library for building adaptors that integrate applications with Open Job Description jobs
Apache License 2.0
11 stars 9 forks source link

Bug: Confusing error message reading configuration files #112

Open ddneilson opened 6 months ago

ddneilson commented 6 months ago

Expected Behaviour

The message should be more informative about what is going on, and not be so alarming. Is this really a warning-level event?

e.g. In this case, the runtime should simply say that the configuration file doesn't exist or just print nothing and move on -- that adaptor doesn't have a configuration file so maybe that's intentional and is not worth logging.

Current Behaviour

Customers see messages like

2024/04/23 17:05:54+00:00 WARNING: Default configuration file at C:\Program Files\Python39\lib\site-packages\deadline\unreal_adaptor\UnrealAdaptor\UnrealAdaptor.json is not a valid file. Using empty configuration.

when the runtime attempts to read the adaptor-local configuration file, but the file does not exist.

Reproduction Steps

Run an adaptor that does not have a local configuration file.

Code Snippet

N/A