OpenKNX / Kaenx-Creator

Create your own KnxProd Files with UI.
MIT License
70 stars 20 forks source link

[addon] check for set display order if PreETS4 is set #56

Closed olterion closed 1 month ago

olterion commented 1 month ago

If the "Is PreETS4" option is activated, the ParameterRefs have to be sorted with the DisplayOrder Parameter. Otherwise the Parameters in ETS are through each other.

thewhobox commented 1 month ago

A workaround is also to deactivate "IsPreETS4". but i dont now which side effects this has.

olterion commented 1 month ago

Yes, this is one solution.

But what i thought to do is: Give every ParameterRef a suitable DisplayOrder number, so the parameters are displayed in the correct sequence.

But the user can choose, which way he wants to go.

thewhobox commented 1 month ago

How is this solved in the original knxprod? Dies any Ref has a DisplayOrder?

olterion commented 1 month ago

Yes, here is a snippet of a vd1 to knxprod converted application (Jung 2138.10 output) You can see, the numbers are not one after the other. The ETS will display the numbers ascending.

          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-104_R-104" RefId="M-0004_A-2060-01-732A-O000A_P-104" Tag="104" DisplayOrder="1000" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-29_R-29" RefId="M-0004_A-2060-01-732A-O000A_P-29" Tag="29" DisplayOrder="1400" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-41_R-41" RefId="M-0004_A-2060-01-732A-O000A_P-41" Tag="41" DisplayOrder="1500" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-73_R-73" RefId="M-0004_A-2060-01-732A-O000A_P-73" Tag="73" DisplayOrder="1600" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-74_R-74" RefId="M-0004_A-2060-01-732A-O000A_P-74" Tag="74" DisplayOrder="1610" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-74_R-83" RefId="M-0004_A-2060-01-732A-O000A_P-74" Tag="83" DisplayOrder="1610" Access="ReadWrite" Value="10" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-74_R-88" RefId="M-0004_A-2060-01-732A-O000A_P-74" Tag="88" DisplayOrder="1610" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-74_R-93" RefId="M-0004_A-2060-01-732A-O000A_P-74" Tag="93" DisplayOrder="1610" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-74_R-98" RefId="M-0004_A-2060-01-732A-O000A_P-74" Tag="98" DisplayOrder="1610" Access="ReadWrite" Value="10" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-74_R-103" RefId="M-0004_A-2060-01-732A-O000A_P-74" Tag="103" DisplayOrder="1610" Access="ReadWrite" Value="10" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-76_R-76" RefId="M-0004_A-2060-01-732A-O000A_P-76" Tag="76" DisplayOrder="1615" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-76_R-81" RefId="M-0004_A-2060-01-732A-O000A_P-76" Tag="81" DisplayOrder="1615" Access="None" Value="0" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-76_R-86" RefId="M-0004_A-2060-01-732A-O000A_P-76" Tag="86" DisplayOrder="1615" Access="None" Value="0" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-76_R-91" RefId="M-0004_A-2060-01-732A-O000A_P-76" Tag="91" DisplayOrder="1615" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-76_R-96" RefId="M-0004_A-2060-01-732A-O000A_P-76" Tag="96" DisplayOrder="1615" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-76_R-101" RefId="M-0004_A-2060-01-732A-O000A_P-76" Tag="101" DisplayOrder="1615" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-75_R-75" RefId="M-0004_A-2060-01-732A-O000A_P-75" Tag="75" DisplayOrder="1620" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-75_R-82" RefId="M-0004_A-2060-01-732A-O000A_P-75" Text="Einschaltverzögerung Basis" Tag="82" DisplayOrder="1620" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-75_R-87" RefId="M-0004_A-2060-01-732A-O000A_P-75" Text="Ein- und Ausschaltverzögerung Basis" Tag="87" DisplayOrder="1620" Access="None" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-75_R-92" RefId="M-0004_A-2060-01-732A-O000A_P-75" Tag="92" DisplayOrder="1620" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-75_R-97" RefId="M-0004_A-2060-01-732A-O000A_P-75" Text="Ein- und Ausschaltverzögerung Basis" Tag="97" DisplayOrder="1620" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-75_R-102" RefId="M-0004_A-2060-01-732A-O000A_P-75" Text="Ein- und Ausschaltverzögerung Basis" Tag="102" DisplayOrder="1620" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-77_R-77" RefId="M-0004_A-2060-01-732A-O000A_P-77" Tag="77" DisplayOrder="1630" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-77_R-79" RefId="M-0004_A-2060-01-732A-O000A_P-77" Tag="79" DisplayOrder="1630" Value="0" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-77_R-84" RefId="M-0004_A-2060-01-732A-O000A_P-77" Tag="84" DisplayOrder="1630" Value="0" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-77_R-89" RefId="M-0004_A-2060-01-732A-O000A_P-77" Tag="89" DisplayOrder="1630" Value="0" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-77_R-94" RefId="M-0004_A-2060-01-732A-O000A_P-77" Tag="94" DisplayOrder="1630" Value="0" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-77_R-99" RefId="M-0004_A-2060-01-732A-O000A_P-77" Tag="99" DisplayOrder="1630" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-78_R-78" RefId="M-0004_A-2060-01-732A-O000A_P-78" Tag="78" DisplayOrder="1640" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-78_R-80" RefId="M-0004_A-2060-01-732A-O000A_P-78" Tag="80" DisplayOrder="1640" Access="None" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-78_R-85" RefId="M-0004_A-2060-01-732A-O000A_P-78" Tag="85" DisplayOrder="1640" Access="None" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-78_R-90" RefId="M-0004_A-2060-01-732A-O000A_P-78" Tag="90" DisplayOrder="1640" Access="None" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-78_R-95" RefId="M-0004_A-2060-01-732A-O000A_P-78" Tag="95" DisplayOrder="1640" Access="None" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-78_R-100" RefId="M-0004_A-2060-01-732A-O000A_P-78" Tag="100" DisplayOrder="1640" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-57_R-57" RefId="M-0004_A-2060-01-732A-O000A_P-57" Tag="57" DisplayOrder="1800" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-58_R-66" RefId="M-0004_A-2060-01-732A-O000A_P-58" Tag="66" DisplayOrder="1850" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-58_R-441" RefId="M-0004_A-2060-01-732A-O000A_P-58" Tag="441" DisplayOrder="1850" Value="1" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-49_R-49" RefId="M-0004_A-2060-01-732A-O000A_P-49" Tag="49" DisplayOrder="1900" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-1_R-1" RefId="M-0004_A-2060-01-732A-O000A_P-1" Tag="1" DisplayOrder="2000" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-30_R-30" RefId="M-0004_A-2060-01-732A-O000A_P-30" Tag="30" DisplayOrder="2400" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-42_R-42" RefId="M-0004_A-2060-01-732A-O000A_P-42" Tag="42" DisplayOrder="2500" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-127_R-127" RefId="M-0004_A-2060-01-732A-O000A_P-127" Tag="127" DisplayOrder="2600" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-128_R-128" RefId="M-0004_A-2060-01-732A-O000A_P-128" Tag="128" DisplayOrder="2610" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-128_R-133" RefId="M-0004_A-2060-01-732A-O000A_P-128" Tag="133" DisplayOrder="2610" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-128_R-142" RefId="M-0004_A-2060-01-732A-O000A_P-128" Tag="142" DisplayOrder="2610" Access="ReadWrite" Value="10" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-128_R-149" RefId="M-0004_A-2060-01-732A-O000A_P-128" Tag="149" DisplayOrder="2610" Access="ReadWrite" Value="10" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-128_R-150" RefId="M-0004_A-2060-01-732A-O000A_P-128" Tag="150" DisplayOrder="2610" Access="ReadWrite" Value="10" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-128_R-153" RefId="M-0004_A-2060-01-732A-O000A_P-128" Tag="153" DisplayOrder="2610" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-131_R-131" RefId="M-0004_A-2060-01-732A-O000A_P-131" Tag="131" DisplayOrder="2615" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-131_R-136" RefId="M-0004_A-2060-01-732A-O000A_P-131" Tag="136" DisplayOrder="2615" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-131_R-140" RefId="M-0004_A-2060-01-732A-O000A_P-131" Tag="140" DisplayOrder="2615" Access="None" Value="0" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-131_R-145" RefId="M-0004_A-2060-01-732A-O000A_P-131" Tag="145" DisplayOrder="2615" Access="None" Value="0" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-131_R-147" RefId="M-0004_A-2060-01-732A-O000A_P-131" Tag="147" DisplayOrder="2615" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-131_R-155" RefId="M-0004_A-2060-01-732A-O000A_P-131" Tag="155" DisplayOrder="2615" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-132_R-132" RefId="M-0004_A-2060-01-732A-O000A_P-132" Tag="132" DisplayOrder="2620" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-132_R-137" RefId="M-0004_A-2060-01-732A-O000A_P-132" Text="Ein- und Ausschaltverzögerung Basis" Tag="137" DisplayOrder="2620" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-132_R-141" RefId="M-0004_A-2060-01-732A-O000A_P-132" Text="Einschaltverzögerung Basis" Tag="141" DisplayOrder="2620" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-132_R-146" RefId="M-0004_A-2060-01-732A-O000A_P-132" Text="Ein- und Ausschaltverzögerung Basis" Tag="146" DisplayOrder="2620" Access="None" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-132_R-148" RefId="M-0004_A-2060-01-732A-O000A_P-132" Text="Ein- und Ausschaltverzögerung Basis" Tag="148" DisplayOrder="2620" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-132_R-154" RefId="M-0004_A-2060-01-732A-O000A_P-132" Tag="154" DisplayOrder="2620" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-129_R-129" RefId="M-0004_A-2060-01-732A-O000A_P-129" Tag="129" DisplayOrder="2630" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-129_R-134" RefId="M-0004_A-2060-01-732A-O000A_P-129" Tag="134" DisplayOrder="2630" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-129_R-138" RefId="M-0004_A-2060-01-732A-O000A_P-129" Tag="138" DisplayOrder="2630" />
          <ParameterRef Id="M-0004_A-2060-01-732A-O000A_P-129_R-143" RefId="M-0004_A-2060-01-732A-O000A_P-129" Tag="143" DisplayOrder="2630" />