search

OpenKinect / libfreenect2

Open source drivers for the Kinect for Windows v2 device
2.08k stars 751 forks source link

Undocumented limits in OpenCL filter config #163

Open xlz opened 9 years ago

xlz commented 9 years ago

The depth result is blank with this config for OpenCL processor:

EnableBilateralFilter = false;
EnableEdgeAwareFilter = true;

It seems the edge aware filter filterPixelStage2 uses max_edge_test which is generated in the bilateral filter filterPixelStage1.

Is this a bug or a limitation in feature?

kohrt commented 9 years ago

I think it is a feature. The edge aware filter is using results of the the bilateral filter. It is also a problem of the opengl processor. Either we should disable edge aware filter if bilateral filter is disabled or add code that calculates this max edge data if the bilateral filter is disable. But how likely is it that someone disabled bilateral filter but still wants to use the edge aware filter?

MichaelKorn commented 9 years ago

For me this is a bug. It should be easy to generate a warning.