OpenKore / openkore

A free/open source client and automation tool for Ragnarok Online
http://openkore.com
Other
1.29k stars 1.05k forks source link

Automatic DC when talking to an NPC #669

Closed FireflySkye closed 7 years ago

FireflySkye commented 7 years ago

[iRO server] The recent update makes my bot dc when it talk to the NPC.

config.txt npcTimeResponse 100 (set it to 1 still the same) npcWrongStepsMethod 0

timeout.txt ai_route_calcRoute 1 ai_route_npcTalk 100 ai_npcTalk 100

ugh..

23

Henrybk commented 7 years ago

Are you using a profiles folder? They are not updated from github, if so please add these to your timeouts.txt

# These timeouts are used in npc conversation (Task::TalkNPC)
ai_npc_talk_wait_to_answer 1.5
ai_npc_talk_wait_after_close_to_cancel 0.5
ai_npc_talk_wait_after_cancel_to_destroy 0.5
FireflySkye commented 7 years ago

Didn't dc but new error 234

Henrybk commented 7 years ago

What console command are you using to talk to this npc? and which npc is it?

FireflySkye commented 7 years ago

move [insertmap] or when it autofollow. any NPC that can teleport. Gramps, Eden Teleporter etc.

Henrybk commented 7 years ago

Sorry for the inconvenience, many updates were made on openkore in the last day regarding this problem, would you please update your openkore to the last version, set logConsole 1 and debug 2 in config.txt and reproduce the error and after give me (post here) the console.txt generated in your logs folder.

This way I'll be able to take a closer look at the problem.

ShishieYo commented 7 years ago

up for this, wthe new update keep disconnecting us when talking to npcs.

kaliwanagan commented 7 years ago

Henrybk commented

Sorry for the inconvenience, many updates were made on openkore in the last day regarding this problem, would you please update your openkore to the last version, set logConsole 1 and debug 2 in config.txt and reproduce the error and after give me (post here) the console.txt generated in your logs folder.

This way I'll be able to take a closer look at the problem.

Did you do this?

ShishieYo commented 7 years ago

Hi,

Please see the attached console log:

angelwell1 commented 7 years ago

Hi sir. I have same problem in lastest version. Hope you fix it, love you :x.

ShishieYo commented 7 years ago

I got Henrybk's TalkNPC.pm! hihi It works now. :) https://raw.githubusercontent.com/Henrybk/openkore/master/src/Task/TalkNPC.pm

FireflySkye commented 7 years ago

@edited by henrybk : Thanks, I'll take a look

Henrybk commented 7 years ago

@FireflySkye How is your autoTalkCont set in config.txt? Also, your talk talk sequence seems wrong, your npc has 3 next interactions and you talk sequence only has 2.

I pointed it in this image: https://i.gyazo.com/e428193f33973f4e39e2a2a0ad76539b.png

If your autoTalkCont set in config.txt is set to 0 you could fix your problem by setting it to 1 or by fixing your talk sequence.

ShishieYo commented 7 years ago

@Henrybk While talking to kafra in payon archer village. it keeps on repeating and cancel talking. Im using yung talkNPC.pm.

Henrybk commented 7 years ago

@ShishieYo You seem to not have updated your timeouts.txt. As you can see here: https://github.com/OpenKore/openkore/commit/bade3aa44b74ca7449a87c80cc771c0facf07e58#diff-542f08fdaa211722f8f3d071e2cbcabc

3 new keys were added.

ShishieYo commented 7 years ago

@Henrybk, I see.. I'll try the code you posted above.

FireflySkye commented 7 years ago

Here are my portals

portals.txt

works before... with no error.

I'm always using xKore 1, so I disable autoTalkCont to 0 Cause if I miss click an NPC I'll get dc.

FireflySkye commented 7 years ago

here. Change my autoTalkCont to 1 console.txt

Henrybk commented 7 years ago

In the first part of this last console you sent you did not have your autoTalkCont set to 1 when you talked to NPC Aperture#acolytewarp and in the second part you were using xKore 1.

Plase correct me if I am wrong.

We might have an issue with xKore but I have got to determine if the talk continuation is working properly, would you please set autoTalkCont to 1 and talk to NPC Aperture#acolytewarp using the same sequence you were using before?

FireflySkye commented 7 years ago

Yes xKore 1, autoTalkCont 0 Here: console.txt

Henrybk commented 7 years ago

@FireflySkye You used the sequence c c r0 c n with only 1 response, but the npc needed 2 responses, the first one being

# Response 0 Yes 1 No 2 Cancel Chat

and the second one being # Response 0 Prontera -> 600z 1 Izlude -> 600z 2 Geffen -> 1200z 3 Payon -> 1200z 4 Morroc -> 1200z 5 Alberta -> 1800z 6 Aldebaran -> 2200z 7 Comodo -> 2200z 8 Umbala -> 2200z 9 Juno -> 1800z 10 Einbroch -> 2200z 11 Lighthalzen -> 2200z 12 Hugel -> 2200z 13 Rachel -> 2200z 14 Cancel 15 Cancel Chat

FireflySkye commented 7 years ago

Hmm. Sorry, I'm lost. my portal sequence is: moc_para01 14 32 prontera 116 72 600 c c r0 c r0 c n

hendra814 commented 7 years ago

Please cek my errror console.txt

FireflySkye commented 7 years ago

This is weird, I tried [not Xkore1] to teleport him to other and they work portals moc_para01 14 32 izlude 131 148 600 c c r0 c r1 c n moc_para01 14 32 geffen 120 39 1200 c c r0 c r2 c n and so on

but for some reason, prontera doesn't work moc_para01 14 32 prontera 116 72 600 c c r0 c r0 c n

O_O. sigh

I gave up. >_> does work if: xKore 0, autoTalkCont 1 prontera sequence doesn't work any config...

if xKore 1 and autoTalkCont [0 or 1] I'll get the same error: Using method 0 defined on config key 'npcWrongStepsMethod' to deal with the error.

Where can I find the info for npcWrongStepsMethod 0 No info on OpenKore Wiki.

hendra814 commented 7 years ago

Please revert back this update, it's so anoying... when character died and back into any town it's get error when talk to kafra...

FireflySkye commented 7 years ago

They can't revert back. I'll just wait for the fix. For now, I disable all interaction to an NPC.

kaliwanagan commented 7 years ago

@FireflySkye or @hendra814 you can always checkout a particular commit version that works for you.

Once you find out which version it is, can you tell us here?

for example, one such commit version is: d6eee2688d70a1bed9d156b4649a231db4072b34

hendra814 commented 7 years ago

how do i know what version i must commit to? or i just checkout for all branch openkore and test it all.

kaliwanagan commented 7 years ago

@hendra814 yes, check out the master branch, do a git log and look at all the merge commits, and test them all.

If you find the merge commit that works, tell us here. It would be super useful to help us debug.

(btw, this is exactly what developers do :P it's just that we're not able to reproduce the bugs you're getting, that's why we have ask you to do it. hopefully you'd eventually be interested enough in dev work to start being able to contribute not just debugging skills, but programming skills too)

kaliwanagan commented 7 years ago

@hendra814 you cna just focus on the merge commits so it's easier for you to test. an example merge commit:

commit 8fc0c8f995ba166c42177ca4aebcf9fc12075781
Merge: 122aa3c43 8a3a1e4cd

It will have the word "Merge: " in the log.

hendra814 commented 7 years ago

@kaliwanagan Sory i don't know what you mean, can you guide step by step to do it.

what i'm just doing is checkout from https://github.com/OpenKore/openkore.git and pick fully recursive

But i've been tried with "Add-sub-for-AI-state-changes" and "Changes-to-plugin-loading-functions" branch and it's working to talk with kafra and doing teleport to another town without getting error

kaliwanagan commented 7 years ago

It's preferred that you use the command line.

First, do a git log Then look for all commit logs that have the "Merge: " in them (like I pasted above) Then do git checkout 8fc0c8f995ba166c42177ca4aebcf9fc12075781 (replace the letters and numbers with the git commit hash that you want to checkout Then run kore in the same folder. If you're still having problems, just checkout the next merge commit.

FireflySkye commented 7 years ago

Ugh. Totally lost. @_@ I got the error starting on July 10 update. errereee

hendra814 commented 7 years ago

@kaliwanagan sorry not tell form the beginning i'm use tortoise svn to update this Ok Git.

but i'm already succes found working OK to talk with NPC it's commit 10245, here my prove untitled

untitled 2

FireflySkye commented 7 years ago

I kinda fix mine too. What I did is, Show log > **Right Click** the Revision #10032 [March 14, 2017] > Revert to this revision then change my portals sequence from moc_para01 14 32 prontera 116 72 600 c c r0 c r0 c n to moc_para01 14 32 prontera 116 72 600 c c c c r0 c r0 c n c

and It works but got a lot of Packet Tokenizer thing.

3456

Sorry I don't know how to check the commit and merge

FireflySkye commented 7 years ago

OK I figure it out. I redownload a fresh openkore (got NO Errorr and less Packet thing) SVN Checkout > URL of Repo: https://github.com/OpenKore/openkore.git/trunk and then the portals.txt, if its a customize NPC sequence you have to put ever talk cont c

moc_para01 14 32 prontera 116 72 600 c c r0 c r0 c n to moc_para01 14 32 prontera 116 72 600 c c c c r0 c r0 c n c

otherwise you'll get the error. I think. >.<

I think. it works now. finally :). Thanks for the help guys!

kaliwanagan commented 7 years ago

@FireflySkye @hendra814 can we confirm that the latest openkore works as well as using the correct talknpc sequence?

hendra814 commented 7 years ago

@kaliwanagan work for teleport or changing map. but for storage still got error, and for storage is it right to use steps c r1 w1 c r0 w1 c

here the error untitled

kaliwanagan commented 7 years ago

@Henrybk I think you might need to look at this :P

hendra814 commented 7 years ago

@kaliwanagan

Done and solved using lastest OK, for storage step use c r1 c r0 and npcWrongMethod 2

Henrybk commented 7 years ago

I will take a look at this :P

Henrybk commented 7 years ago

There was an issue with autoTalkCont 1 and w or a npc steps, I'll get it fixed as soon as I can, the rest seems to be alright.