search

OpenLEADR / openleadr-python

Python library for OpenADR 2.0b
https://openleadr.org/docs
Apache License 2.0
135 stars 55 forks source link

Dependencies aren't pinned #151

Open allanlewis opened 1 year ago

allanlewis commented 1 year ago

Currently, most of the dependencies specified in setup.py aren't pinned. For example, if Jinja2 releases a major version then this package might break for anyone who hasn't pinned that themselves.

It would be good to pin each dependency to the current major version. For Jinja2, it would be nice to support 2.x as well as 3.x as the former is still widely used.

(I'd consider raising a PR for this myself.)

stan-janssen commented 1 year ago

Thanks. I pinned the releases to the current versions up to and excluding the next major version. I tried with the jinja2 2.X version (2.11.3), but that currently fails the integration tests.

If you'd like to add fixes to OpenLEADR to support jinja2 version 2.X, you're welcome to do so and I'll look at your pull request!

Thanks for the help and the interest!

allanlewis commented 1 year ago

Hi @stan-janssen - would you have any objection if I migrated the metadata and dependency management to Poetry?

stan-janssen commented 1 year ago

Sure, thanks. I left a comment on your draft pull request.