search

OpenLEADR / openleadr-rs

OpenADR 3.0 VTN and VEN implementation in Rust
Other
12 stars 4 forks source link

Beginner friendly issues #42

Open KeeganMyers opened 4 weeks ago

KeeganMyers commented 4 weeks ago

I have been extremely interested in the DER and VPP spaces for the past few months and would love to start contributing to this project. I have fairly extensive production Rust experience so once I familiarize myself with the OpenADR specification I would love to start picking up issues. Do you have any suggestions where I should start?

pohlm01 commented 3 weeks ago

Hi Keegan,

thanks a lot for your initiative! I saw that you already picked up some issues in the Docker setup (#43). During the review, I noticed another small bug #45, that you may want to pick up. We are currently preparing the repository for contributions and are happy that we are receiving contributions so early on. I'll try to continue marking issues as "good first issue" where appropriate.

KeeganMyers commented 3 weeks ago

Would it be worthwhile to go through the repo and factor out all the unwraps either by leveraging AppError for more implicit unwraps. Or using asserts where needed. Right now it seems like there would be lots of panics. That makes sense for a CLI if you want it to terminate on failure but for an API its probably not ideal.

KeeganMyers commented 3 weeks ago

Disregard my last comment on review most of these unwraps are from tests. That's what I get for blindly grepping.

pohlm01 commented 3 weeks ago

@KeeganMyers thanks a lot for your last contributions. #43 and #50 are (almost) merged. If you are still interested, feel free to pick any other issue that is still open, or propose an improvement yourself. I recently added a few small to mid-sized issues while writing the client documentation. Maybe one of #48, #54, #55, or #56 is interesting for you. If you want something bigger, you might want to look into #52.