search

OpenLLMAI / OpenRLHF

An Easy-to-use, Scalable and High-performance RLHF Framework (70B+ PPO Full Tuning & Iterative DPO & LoRA & Mixtral)
https://openrlhf.readthedocs.io/
Apache License 2.0
1.73k stars 164 forks source link

Bug: 'ActorModelRayActor' object has no attribute 'actor' #195

Closed hmzo closed 5 months ago

hmzo commented 5 months ago

The reason seems to be that the reference occurs before the assignment in these two lines:

https://github.com/OpenLLMAI/OpenRLHF/blob/main/openrlhf/trainer/ray/ppo_actor.py#L194 https://github.com/OpenLLMAI/OpenRLHF/blob/main/openrlhf/trainer/ray/ppo_critic.py#L98

wuxibin89 commented 5 months ago

Fixed https://github.com/OpenLLMAI/OpenRLHF/pull/197