OpenLake / Sampoorna

One app for all women that covers everything from safety to health and more. 👩💪
MIT License
28 stars 43 forks source link

Improve Edit Texts error visibility in Onboarding User Info Fragment #47

Closed sarveshpatelsp closed 2 years ago

sarveshpatelsp commented 2 years ago

I want to add some toast in onboarding_user_info.xml, and also want to change the font. Please raise my issue. Also If anyone wants to contribute with me, please feel free to dm me in my Linkedin Profile. I am happy to work with you.

Regards, Sarvesh

BudhirajaMadhav commented 2 years ago

@aastha01chauhan what's your view on this? Do we need something like this?

yellowHatpro commented 2 years ago

Hello @sarveshpatelsp , yes you can work on this issue. Instead of a toast, I'd recommend using the material text fields set error feature.

sarveshpatelsp commented 2 years ago

@yellowHatpro Thanks for giving me this opportunity. I will give my best.

yellowHatpro commented 2 years ago

Hello @sarveshpatelsp are you still working on this issue?

sarveshpatelsp commented 2 years ago

Hello @yellowHatpro, Yes, I am still working on this. Sorry, for the delay, actually I am having my Mid Sem Tests and also have those assignments to complete. So I am too busy nowadays. Please, don't mind. I am also a newbie in this field. I hope you'll understand my problem. Thank You,

yellowHatpro commented 2 years ago

Hello @sarveshpatelsp , any update so far? If you have any problems, you can discuss them on the channel.

yellowHatpro commented 2 years ago

Can anyone else work on this issue?

ken1000minus7 commented 2 years ago

I can work on this issue. What exactly needs to be done? Adding toast sounds pretty vague 😅

yellowHatpro commented 2 years ago

Hello @ken1000minus7 , thanks for showing interest in the issue. Yeah, the name of the issue was not clear. We have to use the Material Edit setError property for showing an error if the user skips any EditText field.