search

OpenLake / Sampoorna

One app for all women that covers everything from safety to health and more. 👩💪
MIT License
28 stars 43 forks source link

Fixed #40: Self Care Fragment Implemented with Grid View #51

Closed MohitGupta121 closed 2 years ago

MohitGupta121 commented 2 years ago

Fixed #40

Self-Care Fragment Implemented with Grid View Below is the screen recording of implementation:-

https://user-images.githubusercontent.com/76530270/158836218-15c86de0-be05-4cd2-a04b-a30abb6f581c.mp4

MohitGupta121 commented 2 years ago

@aastha01chauhan @BudhirajaMadhav @yellowHatpro can you please review this PR fro issue #40 As I have no idea for icons that's why I use same icons but we can change.

yellowHatpro commented 2 years ago

Looks good, but there are a few things I would like to point out:

  1. The icon for self-care doesn't reflect its purpose, please use some other relevant one.
  2. The margin for the cards in the grid are not proper, please give a proper margin for the cards. These changes should be sufficient for now, and we will be adding more later then.
MohitGupta121 commented 2 years ago

Looks good, but there are a few things I would like to point out:

  1. The icon for self-care doesn't reflect its purpose, please use some other relevant one.
  2. The margin for the cards in the grid are not proper, please give a proper margin for the cards. These changes should be sufficient for now, and we will be adding more later then.
  1. Can you suggest some icon for that.
  2. Which margin u r taking about not understood??
MohitGupta121 commented 2 years ago

@yellowHatpro Can you suggest some icon for that. Which margin u r taking about not understood??

MohitGupta121 commented 2 years ago

@yellowHatpro @aastha01chauhan I can you please now review I changes that u requested can you suggest bottom menu icon for self-care

MohitGupta121 commented 2 years ago

@yellowHatpro @aastha01chauhan can u please add level tag in PR as per Gssoc

MohitGupta121 commented 2 years ago

@yellowHatpro @aastha01chauhan is there any update on my PR can u please review