OpenLauncherTeam / openlauncher

Customizable and Open Source Launcher for Android
Apache License 2.0
1.41k stars 413 forks source link

reorganize and clean Fastlane structure #656

Closed IzzySoft closed 2 years ago

IzzySoft commented 3 years ago

see #655 – this reorg should enable F-Droid to use the project's metadata, thus giving you full control over descriptions, screenshots etc. According to the Fastlane structures

I hope I caught it all, please cross-check. You can always build on this, I hope my above linked "Cheat-Sheet" proves helpful.

Once this PR was merged and a new tag is available, please let us (at F-Droid) know so we can switch to the new metadata. I'll gladly make the corresponding MR at fdroiddata for you as well.

gsantner commented 3 years ago

What I don't quite get is what you mean with

Once this PR was merged and a new tag is available, please let us (at F-Droid) know so we can switch to the new metadata. I'll gladly make the corresponding MR at fdroiddata for you as well.

..fdroidserver usually picks up the metadta from the tagged commit and if it's there it works as is. Or is there something new that I don't know yet?

please let us (at F-Droid)

BTW, while I'm not much active recently ... I'm also in the F-Droid GitLab maintainers/contributors group/role :D.

IzzySoft commented 3 years ago

..fdroidserver usually picks up the metadta from the tagged commit and if it's there it works as is. Or is there something new that I don't know yet?

Maybe: "order of precendence".

Currently, for OpenLauncher there are local summary.txt overwriting your short_description.txt – and the description inside the .yml overwriting your en-US/full_description.txt. Those must be removed – but not before your Fastlane is tagged and picked.

That said: let me fetch those short descriptions and add them to your Fastlane, so the work of our translators was not in vain. That OK with you? Will bring you short descriptions for 16 additional languages if you'd take them.

BTW, while I'm not much active recently ... I'm also in the F-Droid GitLab maintainers/contributors group/role :D.

If you wish, you could initiate the MR then yourself :smiley:

IzzySoft commented 3 years ago

let me fetch those short descriptions and add them to your Fastlane

Can be done with a separate PR as well if you prefer – so feel free going ahead and merging this one as-is :wink:

gsantner commented 2 years ago

thx merged

IzzySoft commented 2 years ago

Great! Thanks! Continuing in the issue then.