Add app shortcuts on longpress

OpenLauncherTeam / openlauncher

Customizable and Open Source Launcher for Android

Apache License 2.0

1.41k stars 413 forks source link

Add app shortcuts on longpress #660

Closed NetLagina closed 2 years ago

NetLagina commented 2 years ago

Add app shortcuts (#648) in Home screen and All apps screen (API 25+).

List _shortcutInfo field was added to App and Item classes
PopupDynamicIconLabelItem class was added to handle text and icon specific for each app
AbstractPopupIconLabelItem abstract class was added as a parent to PopupIconLabelItem and PopupDynamicIconLabelItem

Known issue/android bug: Launcher can't get app shortcuts until set as a default launcher.

Before: Screenshot_1633186974 After: Screenshot_1633187035 Screenshot_1633187057 .

gsantner commented 2 years ago

thank you

you still work on it right?

NetLagina commented 2 years ago

Hello @gsantner! Today's two commits were the last. In my opinion, the required minimum has been implemented, but maybe there will be some requests / requirements from you?

gsantner commented 2 years ago

I dont actively develop it since some time, no. But I use it everyday.

Most important is that it does not create (new) crashes/stability. So most importantly, install it on your device(s) and use the build for a few days as your main launcher. Thats how you find out best.

NetLagina commented 2 years ago

Is it a bug or a feature that in the locked desktop mode you cannot call a popup with at least the "Info" and "Remove" items?

gsantner commented 2 years ago

Popup should appear. However, no remove/resize/move/rename buttons, or add item.

But it is another topic, think somebody opened a issue already. If you see it easy fixable on-the-go here, you can, otherwise you can split to new PR.

NetLagina commented 2 years ago

I added popup appearing in locked mode. It was problematic to do this as a separate PR, since the presence of current changes from this PR was required, so I add here. I've tested these changes for about 2 weeks.

gsantner commented 2 years ago

@NetLagina
Can you please resolve the merge conflict and mention me then?
I trust you that it's working as expected as you tried for quite some time now. Merging then.

Btw, I merged in the PWA pull request, might be clashing at some points

NetLagina commented 2 years ago

@gsantner merge conflict resolved

gsantner commented 2 years ago

@NetLagina thx, so ready to merge? or have you noticed problems since the merge?

NetLagina commented 2 years ago

@gsantner yes, it is ready to merge.