OpenLiberty / ci.common

Common functionality for ci.maven and ci.gradle
Apache License 2.0
3 stars 30 forks source link

Compose version parameters for binary scanner and handle errors #381

Closed turkeylurkey closed 2 years ago

turkeylurkey commented 2 years ago

Instead of hard coding the parameters passed to the binary scanner we will compose the parameter from the information in the build file. If the build file specifies a version number that the binary scanner does not support it will throw an invalid argument exception which we report.

This pull request is also a bit of a design review. We could request a better API from the binary scanner regarding invalid version numbers but the current arrangement looks pretty safe. Also the message we report should be reviewed.