search

OpenLiberty / ci.docker

Eclipse Public License 1.0
42 stars 59 forks source link

Consider a build argument or env to skip the generation of default keystore and truststore config #398

Open leochr opened 1 year ago

leochr commented 1 year ago

Liberty container image includes scripts (configure.sh, startup) that generate the default keystore. It's added to /config/configDropins/defaults. Provide a build arg/env to skip the generation of the default keystore

Relevant issue: https://github.com/WASdev/ci.docker/issues/493#issuecomment-1464657178

Also, consider providing an option to skip the generation of the default truststore. The default truststore.xml is written to configDropons/overrides, not sure what the historical reason is. This would override the user-specified truststore config in server.xml as well.

pugmas commented 1 year ago

Hi @leochr , maybe I'm wrong, but isn't there already an environment variable for this?

ENV KEYSTORE_REQUIRED "false"

https://hub.docker.com/_/open-liberty

leochr commented 1 year ago

@pugmas That env variable must have existed in previous tags (i.e. webProfile), but the current set of images with kernel-slim and full tags don't include/support it.