search

OpenLiberty / ci.docker

Eclipse Public License 1.0
42 stars 59 forks source link

Add call to the OpenAPI endpoint during SCC generation #525

Closed jdmcclur closed 2 months ago

jdmcclur commented 3 months ago

Add call to the OpenAPI endpoint during SCC generation. This will improve first request performance.

jdmcclur commented 2 months ago

@leochr 24.0.0.4+ is fine.

leochr commented 2 months ago

@jdmcclur sounds good. Please remove the changes to the 23.0.0.3 folder. We are still waiting for the 24.0.0.4 baseline to be created.

Also, it'll be good to update the README to mark these config options with 24.0.0.4+. Thank you.

leochr commented 2 months ago

@jdmcclur Once above comments are addressed, we can merge the changes to the latest folder first and then deal with 24.0.0.4. The baseline PR for 24.0.0.4 might carry the changes from the latest folder to the 24.0.0.4 folder, but I am not entirely sure. If it doesn't, then a separate PR for 24.0.0.4 will be needed.

leochr commented 2 months ago

@jdmcclur Similar comment as WebSphere Liberty: 24.0.0.4 baseline files were just merged. Please rebase (to add the changes to 24.0.0.4 and remove from 23.0.0.3). Sorry to rush, but we need to get this merged soon, before the builds to produce 24.0.0.4 images with the GM driver are run later today. Thank you.