OpenLiberty / ci.maven

Maven plugins for managing Liberty profile servers #devops
Apache License 2.0
130 stars 91 forks source link

runtimeArtifact warning #1102

Closed Joseph-Cass closed 1 year ago

Joseph-Cass commented 3 years ago

Perhaps this will be covered by #1043 but currently defining a <runtimeArtifact> gives the following warning for me:

Invalid plugin configuration: runtimeArtifact

Should this be the case?

image

scottkurz commented 3 years ago

@Joseph-Cass this is in Eclipse I assume? Not sure the liberty-maven-plugin can do anything about this but maybe just for the record, what version of Eclipse and m2e (I assume that's what you're using) are you running with?

I did stumble on this issue..wonder if it's related: https://bugs.eclipse.org/bugs/show_bug.cgi?id=563035

cherylking commented 3 years ago

@Joseph-Cass In the 3.0 release runtimeArtifact replaced assemblyArtifact. Either you are hitting the bug that Scott mentioned above, or Eclipse does not recognize the new name for that configuration parameter.

Joseph-Cass commented 3 years ago

Yes, this is in Eclipse. My Eclipse version is:

Eclipse IDE for Java Developers (includes Incubating components)
Version: 2020-12 (4.18.0)

My Apache Maven version is:

Josephs-MBP:api josephcass$ mvn --version
Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T20:00:29+01:00)
Maven home: /usr/local/Cellar/maven/3.6.1/libexec
Java version: 13.0.2, vendor: AdoptOpenJDK, runtime: /Library/Java/JavaVirtualMachines/adoptopenjdk-13-openj9.jdk/Contents/Home
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "10.16", arch: "x86_64", family: "mac"

I did notice that the attached "doc" that Eclipse generates for <assemblyArtifact> is the same as it is for <runtimeArtifact>:

required: false
type: org.codehaus.mojo.pluginsupport.util.ArtifactItem
expression: ${runtimeArtifact}

Maven coordinates of a server assembly. This is best listed as 
 a dependency, in which case the version can be omitted.

Yet the warning doesn't show for <assemblyArtifact>. Not sure if that's useful info?

Thanks!

cherylking commented 1 year ago

Not sure if this is still an issue, but if it is we don't plan on fixing it.