search

OpenLiberty / ci.maven

Maven plugins for managing Liberty profile servers #devops
Apache License 2.0
130 stars 91 forks source link

Add late prop resolution for Liberty configuration specified by Maven props #1706

Closed cherylking closed 1 year ago

cherylking commented 1 year ago

Fixes #1705 @bmarwell

Question: Do we only need to resolve the @{xxx} properties that are referenced in Maven properties? Or do we also need to handle them in the configuration parameters for the plugin (such as the jvmOptions parameter)?

Answer: Yes, we should handle them in other config parameters for consistency. I have implemented the behavior for the jvmOptions and the bootstrapProperties in this PR.

Also, I presume we do not need to look for and resolve these types of references in config files specified by other parameters such as jvmOptionsFile. Correct me if I am wrong.

Answer: We should not look for / resolve these references in config files other than pom.xml.

cherylking commented 1 year ago

This is the documentation I plan to add for this.

Screenshot 2023-07-12 at 1 55 01 PM

This will go at the end of the common-server-parameters.md.